Skip to content

Pass through u128 hashes to the hashmap #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Pass through u128 hashes to the hashmap #18

wants to merge 2 commits into from

Conversation

@bluss
Copy link

@bluss bluss commented Aug 5, 2025 •
edited
Loading

Since this u128 is already a good hash (from siphash13), use one part of it (lower u64 word) as the hash for the hashmap.

This is a draft, since it has not been benchmarked.
@bluss
Pass through u128 hashes to the hashmap
a7c3961 
Since u128 is already a good hash, use one part of it (lower u64 word)
as the hash for the hashmap.
@bluss bluss force-pushed the passthrough-hasher branch from bb61c6b to a7c3961 Compare August 5, 2025 09:32
@bluss
Copy link
Author

bluss commented Aug 5, 2025

@laurmaedje said

unfortunately, it seems to barely make a difference (for Typst), just ~0.05% fewer instructions on average

so then with no supporting evidence for it, there is no gain from this change.
@bluss bluss closed this Aug 5, 2025
@bluss bluss reopened this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@bluss