-
Notifications
You must be signed in to change notification settings - Fork 613
notify large json (#182, #186) #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ArjunCodess
wants to merge
323
commits into
triggerdotdev:main
from
ArjunCodess:bug/notify-large-json-182-186
Closed
notify large json (#182, #186) #206
ArjunCodess
wants to merge
323
commits into
triggerdotdev:main
from
ArjunCodess:bug/notify-large-json-182-186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 09bed34 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 8 14:03:50 2022 +0100 Fixed the layout of a search list item commit 90126d4 Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 17:25:13 2022 +0100 Insanely complicated path search results highlighitng and truncating commit a4bbd55 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 14:05:01 2022 +0100 Improved the title editing in the header commit 5814053 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 13:38:33 2022 +0100 Improved text highlight colour commit 110de37 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 13:36:57 2022 +0100 Icon hover state now uses isHighlighted commit fb6da94 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 13:31:11 2022 +0100 Light mode styling commit 2c378d5 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 12:24:43 2022 +0100 Spacing between search items no longer a hack commit 85d90bb Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 12:19:10 2022 +0100 Added ellipsis to search matches if they are windowed commit 91f3e70 Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 12:08:00 2022 +0100 Fixed search item icons commit e384c87 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 11:52:58 2022 +0100 Improved hover state commit f4681ed Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 11:47:33 2022 +0100 Removed focus state on button commit faa2d06 Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 11:26:42 2022 +0100 made the search palette a little bigger commit df8bd52 Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 11:26:14 2022 +0100 Remove onOverlayClick prop commit ecd046b Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 11:18:46 2022 +0100 Close search when the overlay is clicked commit fba330b Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 11:10:35 2022 +0100 hitting esc when search input is focused and empty should close the search commit fc2fe8a Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 11:00:08 2022 +0100 Highlight the window of the best search match in the search results commit 45193ec Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 10:45:01 2022 +0100 Now you can arrow down to the last item in the list commit 0de5fef Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Apr 1 10:37:20 2022 +0100 Added a hacky margin between items and remove the transition to make it feel snappier commit 167b548 Author: Eric Allam <eallam@icloud.com> Date: Fri Apr 1 09:30:33 2022 +0100 WIP implementing search commit 5655631 Author: James Ritchie <james@jamesritchie.co.uk> Date: Fri Mar 25 15:28:19 2022 +0000 Build and styled search modal commit e368db8 Author: Eric Allam <eallam@icloud.com> Date: Fri Mar 25 14:42:03 2022 +0000 Implement JSON search through fuse.js + web worker + react hook commit 8caa11b Author: Eric Allam <eallam@icloud.com> Date: Wed Mar 23 10:21:33 2022 +0000 Start of the Command Palette using radix-ui Dialog commit 904b64d Author: Eric Allam <eallam@icloud.com> Date: Wed Mar 23 09:58:52 2022 +0000 Uncommented out the search bar field
…em in the root object
…escription, and fix the issue where the label wasn’t showing when there was no label match
Convert search from Fuse.js to @jsonhero/fuzzy-json-search
…w the first time you want to move
* Replace peekalink with OpenGraph Ninja API * Switch to url.href for OpenGraph call
* Load URI preview based on network state * Handle URL preview endpoint failures * Inline response * Formats code * Improve performance * Improve code
Co-authored-by: = <rahulkumar@metafic.co>
fix: 🐛 handle the array use case first in the stableJson util
feat: use random user agent header when fetching JSON url's
Improve error handling
Stop sending events go graphJSON
- Add try-catch block to handle JSON parsing errors in createFromRawJson function - Improve error messages for invalid JSON format during parsing and validation - Ensure consistent error handling across JSON operations
- Add try-catch block to handle errors during JSON file processing - Implement specific error messages for invalid JSON format and file size issues - Set error messages in toast notifications for user feedback - Redirect to home with updated session cookie on error
- Add error messages for file reading issues and invalid JSON format - Implement specific feedback for file size and type rejections - Update maximum file size limit to 5MB - Display error messages to users in the UI for better feedback
Author
|
@matt-aitken hey! :) if there is anything left to implement / anything to be edited, please let me know! |
Author
|
@matt-aitken just a follow-up. |
1 similar comment
Author
|
@matt-aitken just a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #186 and #182 by improving file size handling and error notifications.
Changes
File size handling
maxSize: 1024 * 1024 * 5)onDropRejectedwith clear error messagesError handling
User experience
Technical details
Client-side (
DragAndDropForm.tsx)Server-side (
createFromFile.ts)JSON validation (
jsonDoc.server.ts)Issues resolved
Issue #186: "Notify if file is too big"
Issue #182: "Local JSON Hero failing on 25K line file"
Testing
Screenshots
Before
After
Breaking changes
None.
Checklist
Related issues
Additional notes
This improves the experience for large JSON files while maintaining performance and reliability. Users get clear, actionable feedback when encountering file size or JSON parsing issues.