fix: Ctrl+A should select all text in CodeEditor #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/components/CodeEditor.tsx
Outdated
Comment on lines
99
to
112
| useEffect(() => { | ||
| const listener = (event: WindowEventMap["keydown"]) => { | ||
| if ((event.ctrlKey || event.metaKey) && event.key === "a") { | ||
| event.preventDefault(); | ||
| view?.dispatch({ selection: { anchor: 0, head: state?.doc.length } }); | ||
| } | ||
| }; | ||
|
|
||
| window.addEventListener("keydown", listener); | ||
|
|
||
| return () => { | ||
| window.removeEventListener("keydown", listener); | ||
| }; | ||
| }, [view, state]); |
There was a problem hiding this comment.
I recommend tinykeys for shortcuts management for this kind of project.
import tinykeys from 'tinykeys'
function useHotKey(params: Parameters<typeof tinykeys>[1]) {
useEffect(() => {
const unsubscribe = tinykeys(window, params)
return () => {
unsubscribe()
}
}, [ params ])
}useHotKey({
"$mod+A": () => {
event.preventDefault();
view?.dispatch({ selection: { anchor: 0, head: state?.doc.length } });
}
})Mac: $mod = Meta (⌘)
Windows/Linux: $mod = Control
Member
There was a problem hiding this comment.
We actually already use the react-hotkeys-hook package in a bunch of different places, e.g.: https://github.com/triggerdotdev/jsonhero-web/blob/main/app/components/SearchBar.tsx#L18
Author
There was a problem hiding this comment.
Should I change this to react-hotkeys-hook?
for <CodeEditor />
Author
|
Although this PR is ready but a similar PR has been merged already (#164) so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality that if
CodeEditoris rendered on screen thenCmd+A/Ctrl+Awill select all the text insideCodeEditor.For this solution I have added a event listener on
window. Here a global event listener is the last option. I was not able to find a CodeMirror solution. Even if there is a CodeMirror solution we will need to enable cursor so the user knows whenCtrl+Awill work./claim #162