Skip to content

Conversation

@yardenshoham
Copy link

@yardenshoham yardenshoham commented Nov 29, 2022

Just to make sure all popular spellings of "color" are parsed

@matt-aitken
Copy link
Member

matt-aitken commented Nov 29, 2022

Hi @yardenshoham, most of our team are British so we feel your pain on colour vs color.

Your change won't improve anything for that though. The cases in that switch statement are going over the returned "type" of strings we support. That's determined in a separate package we created that infers the type from the value.

A colour is determined by if it's a valid colour hex code or a certain predefined string (e.g. "yellow").

Is there an instance of a colour not being correctly identified that you've seen? If so I can point you at where to fix that or I can take a look.

@yardenshoham
Copy link
Author

Hi @matt-aitken, I saw it here

@yardenshoham yardenshoham deleted the patch-1 branch November 29, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants