Skip to content

Feat: group array item by its length in related values panel. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2022
Merged

Feat: group array item by its length in related values panel. #126

merged 3 commits into from
Oct 18, 2022

Conversation

@cesaryuan
Copy link
Contributor

@cesaryuan cesaryuan commented Oct 18, 2022 •
edited
Loading

@ericallam
Copy link
Member

ericallam commented Oct 18, 2022

Good idea! Could we change it so the output is Array(${length}) instead? So if it was an array of length 4 it would be shown as Array(4)
@cesaryuan
Copy link
Contributor Author

cesaryuan commented Oct 18, 2022

Good idea! Could we change it so the output is Array(${length}) instead? So if it was an array of length 4 it would be shown as Array(4)

Hi, thanks for you reply. It's a good advice and I have changed to it. You can check it.
@cesaryuan
Copy link
Contributor Author

cesaryuan commented Oct 18, 2022

I'm still wondering if there is a better format for object item ("{...}"). Do you have any idea? 😊
@ericallam ericallam merged commit b7ae119 into triggerdotdev:main Oct 18, 2022
@ericallam
Copy link
Member

ericallam commented Oct 18, 2022

Sorry don't have any ideas for the object, but if you come up with anything please open another PR :)
@cesaryuan cesaryuan deleted the issue-124 branch October 19, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@cesaryuan @ericallam