Skip to content

Actually stop BLE scan in StopScan() on nrf528xx #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Actually stop BLE scan in StopScan() on nrf528xx #398

wants to merge 1 commit into from

Conversation

@zopieux
Copy link

@zopieux zopieux commented Nov 27, 2025

Tested on a nrf52840 board.

Without this patch, calling

Scan()
(sleep)
StopScan()
err := Scan()

returns an error on the second Scan() because the previous scan wasn't actually stopped, since the native call is missing.

With this patch, the above succeeds and the scan starts returning results, as usual.

I'm really not sure why there was a TODO rather than this simple function call. The TODO doesn't provide a rationale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@zopieux