common: improve verbosity level definitions #17630
Merged
+46
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This change is part of the plan to use server code inside CLI)
The current log verbosity is not very useful as it only has 3 levels: (-1) logs nothing, (0) default, (1) debug
This PR adds more hierarchy so that "the higher verbosity number, more stuff get logged":
For CLI and most applications, the output (for example, generated text, json, csv, etc) can be written using
LOG_LEVEL_OUTPUT, which is equivalent to theLOG(...)macroThe default verbosity for future CLI application (server based) will ideally be ERROR, this is because WARN also log some redundant stuff in the middle of the conversation