Skip to content

Add tqdm to pandas_to_eland() #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tqdm to pandas_to_eland() #299

wants to merge 1 commit into from

Conversation

@V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Oct 26, 2020

Closes #294

  • Added tqdm functionality for pandas_to_eland()

  • If we want the progress bar to disappear we will need to just add leave=False to tqdm context manager at line 234

@sethmlarson

Please review if the implementation is correct, I will add notebook tests for this once review is done. 😃
@elasticmachine
Copy link

elasticmachine commented Oct 26, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?
@V1NAY8 V1NAY8 force-pushed the add-tqdm branch 2 times, most recently from c22fcd3 to f1d7824 Compare October 28, 2020 11:07
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Oct 28, 2020

Added tests, updated requirements*.txt
sethmlarson
sethmlarson suggested changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, few comments for you
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020 •
edited
Loading

Yep @sethmlarson , Made changes,
Also in setup.py install-requires has elasticsearch>=7.7, but in our jenkins matrix we also test for 7.6.
Should I remove it?
@V1NAY8 V1NAY8 requested a review from sethmlarson November 16, 2020 18:46
@sethmlarson
Copy link
Contributor

sethmlarson commented Nov 16, 2020

I'll handle the elasticsearch-py stuff, there's a subtle change that needs to be made regarding which elasticsearch-py version to install
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020

Ask jenkins to test this please
@sethmlarson
Copy link
Contributor

sethmlarson commented Nov 16, 2020

jenkins test this please
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020

Also I took reference for ipython check from
ipython/ipython#9732 (comment)
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Jan 21, 2021

@sethmlarson Anything else required on this change?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@V1NAY8 @elasticmachine @sethmlarson