Add an option to disable the existence check #1112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejdro
force-pushed
the
disable-check
branch
from
2724c82 to
56dda5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds an option to disable filtering by the existing files. The issue with that feature is that, if some files are on a slow medium, like a network drive, accessing them can take a while, slowing down everything significantly.
Files will still eventually get discarded from the database by the aging algorithm, so I consider this a good tradeoff.
After investigating #1044 for a bit, I came to the conclusion that the filtering for the existing files seems to be the culprit. I can't say for certain, but after disabling and running for a while, I could not reproduce the issue anymore.
This fixes #1044