Skip to content

Conversation

@varinotmUnity
Copy link
Contributor

DO NOT FORGET TO INCLUDE A CHANGELOG ENTRY

Purpose of this PR

A change to the editor created warning : "The type Unity.ProBuilder UnityEngine.ProBuilder.Shapes.Cube is being serialized by [SerializeReference], but is missing the [Serializable] attribute. To suppress this warning add [Serializable] or use [MakeSerializable].” warning is thrown"

This was fixed by adding serilizable to all the probuilder shape classes.

Links

https://jira.unity3d.com/browse/PBLD-279

Comments to Reviewers

N/A

@u-pr-agent
Copy link

u-pr-agent bot commented Nov 28, 2025

PR Reviewer Guide 🔍

(Review updated until commit 416e9ed)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

PBLD-279 - PR Code Verified

Compliant requirements:

  • Added [System.Serializable] attribute to all Shape classes (Arch, Cone, Cube, Cylinder, Door, Pipe, Plane, Prism, Sphere, Sprite, Stairs, Torus).

Requires further human verification:

  • Verify in the Unity Editor that creating ProBuilder objects (like Arch, Cube, etc.) no longer triggers the serialization warning in the console.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The changes are repetitive and simple (adding an attribute) across multiple files, with some minor whitespace cleanup, making it very quick to review.
🏅 Score: 98

The PR correctly implements the fix suggested by the warning message, includes a changelog entry, and cleans up trailing whitespace.
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link

u-pr-agent bot commented Nov 28, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@u-pr-agent
Copy link

u-pr-agent bot commented Nov 28, 2025

Persistent review updated to latest commit dc6b640

@u-pr-agent
Copy link

u-pr-agent bot commented Nov 28, 2025

Persistent review updated to latest commit 416e9ed

1 similar comment
@u-pr-agent
Copy link

u-pr-agent bot commented Nov 28, 2025

Persistent review updated to latest commit 416e9ed

@codecov-github-com
Copy link

codecov-github-com bot commented Nov 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   35.57%   35.57%           
=======================================
  Files         277      277           
  Lines       34892    34892           
=======================================
  Hits        12413    12413           
  Misses      22479    22479           
Flag Coverage Δ
mac_trunk 35.34% <ø> (ø)
win_trunk 35.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Runtime/Shapes/Arch.cs 62.69% <ø> (ø)
Runtime/Shapes/Cone.cs 66.66% <ø> (ø)
Runtime/Shapes/Cube.cs 77.77% <ø> (ø)
Runtime/Shapes/Cylinder.cs 73.45% <ø> (ø)
Runtime/Shapes/Door.cs 67.70% <ø> (ø)
Runtime/Shapes/Pipe.cs 65.00% <ø> (ø)
Runtime/Shapes/Plane.cs 54.38% <ø> (ø)
Runtime/Shapes/Prism.cs 66.66% <ø> (ø)
Runtime/Shapes/Sphere.cs 76.66% <ø> (ø)
Runtime/Shapes/Sprite.cs 70.96% <ø> (ø)
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants