-
Notifications
You must be signed in to change notification settings - Fork 88
make all probuilder shapes serializable to avoid warning #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍(Review updated until commit 416e9ed)Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit dc6b640 |
|
Persistent review updated to latest commit 416e9ed |
1 similar comment
|
Persistent review updated to latest commit 416e9ed |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## master #642 +/- ##
=======================================
Coverage 35.57% 35.57%
=======================================
Files 277 277
Lines 34892 34892
=======================================
Hits 12413 12413
Misses 22479 22479
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DO NOT FORGET TO INCLUDE A CHANGELOG ENTRY
Purpose of this PR
A change to the editor created warning : "The type Unity.ProBuilder UnityEngine.ProBuilder.Shapes.Cube is being serialized by [SerializeReference], but is missing the [Serializable] attribute. To suppress this warning add [Serializable] or use [MakeSerializable].” warning is thrown"
This was fixed by adding serilizable to all the probuilder shape classes.
Links
https://jira.unity3d.com/browse/PBLD-279
Comments to Reviewers
N/A