Skip to content

Fix reading ReadCraftingOrderItem for >= 11.0.2 #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix reading ReadCraftingOrderItem for >= 11.0.2 #949

wants to merge 2 commits into from

Conversation

@Asaelle
Copy link
Contributor

@Asaelle Asaelle commented Jul 1, 2025

No description provided.

Shauren
Shauren reviewed Jul 4, 2025
View reviewed changes
WowPacketParserModule.V10_0_0_46181/Parsers/CraftingHandler.cs
public static void ReadCraftingOrderNpcCustomer(Packet packet, params object[] indexes)
{
packet.ReadInt64("NpcCraftingOrderCustomerID", indexes);
packet.ReadInt32("NpcCraftingOrderSetFlags", indexes);
Copy link
Member

@Shauren Shauren Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did you get this name from?
Copy link
Contributor Author

@Asaelle Asaelle Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mix of both RE & guessed, you can delete it, the dev don't remember exactly but have did these flags name if that can help you

enum NpcCraftingOrderSetFlags : uint32
{
    CraftingOrderFlagAllowMultiple = 0x01,
    CraftingOrderFlagAllowDuplicate = 0x02
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Asaelle @Shauren