Skip to content

cpu/cortexm_common: use picolibc by default #19061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

cpu/cortexm_common: use picolibc by default #19061

wants to merge 7 commits into from
+81 −39

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Dec 16, 2022 •
edited
Loading

Contribution description

picolibc is multiple kb smaller than newlib and generally geared towards bare metal systems (instead of deeply embedded Linux systems), so it's the better choice.

We now have a recent version of picolibc on CI, so let's try switching to it by default on Cortex-M.

Testing procedure

Issues/PRs references
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 16, 2022
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Dec 16, 2022
@benpicco benpicco requested a review from maribu December 16, 2022 17:06
@riot-ci
Copy link

riot-ci commented Dec 16, 2022 •
edited
Loading

Murdock results

❌ FAILED

314fd71 sys/usb: select USE_STDOUT_BUFFERED for stdio_cdc_acm

Build failures (21)
Application Target Toolchain Runtime (s) Worker
examples/lua_basic arduino-mkrzero gnu 1.86 breeze
examples/lua_basic adafruit-itsybitsy-m4 gnu 2.00 breeze
examples/lua_basic mulle gnu 3.63 riotbuild
examples/lua_basic bastwan gnu 4.01 tatooine
examples/lua_basic samd10-xmini gnu 3.20 tatooine
examples/lua_basic nucleo-l011k4 gnu 4.72 mobi7
examples/lua_basic weact-f401ce gnu 9.57 comsys
tests/driver_aip31068 adafruit-itsybitsy-m4 gnu 1.22 breeze
tests/driver_aip31068 arduino-mkrzero gnu 4.76 comsys
tests/driver_aip31068 bastwan gnu 5.90 mobi7
tests/driver_aip31068 weact-f401ce gnu 7.58 mobi3
tests/driver_bme680 adafruit-itsybitsy-m4 gnu 7.25 tatooine
tests/driver_bme680 bastwan gnu 1.57 breeze
tests/driver_bme680 arduino-mkrzero gnu 7.18 comsys
tests/driver_bme680 weact-f401ce gnu 3.38 tatooine
tests/driver_ili9341 adafruit-itsybitsy-m4 gnu 3.19 comsys
tests/driver_ili9341 arduino-mkrzero gnu 3.09 mobi3
tests/driver_ili9341 avsextrem gnu 2.58 mobi7
tests/driver_ili9341 bastwan gnu 1.67 breeze
tests/driver_ili9341 z1 gnu 2.23 mobi7

and 481 more build failures...

Artifacts
@benpicco benpicco force-pushed the cpu/cortexm_common-picolibc branch from e7f99c2 to fda2bca Compare December 16, 2022 17:15
@benpicco benpicco added the Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR label Dec 16, 2022
@github-actions github-actions bot removed the Area: Kconfig Area: Kconfig integration label Dec 16, 2022
@benpicco benpicco force-pushed the cpu/cortexm_common-picolibc branch from fda2bca to 905d103 Compare December 16, 2022 17:18
@github-actions github-actions bot added the Area: Kconfig Area: Kconfig integration label Dec 16, 2022
@github-actions github-actions bot added Area: pkg Area: External package ports Area: sys Area: System labels Dec 16, 2022
@benpicco benpicco force-pushed the cpu/cortexm_common-picolibc branch from 06cad16 to 97de61b Compare December 16, 2022 18:36
@benpicco benpicco force-pushed the cpu/cortexm_common-picolibc branch from 97de61b to 36ec90e Compare December 16, 2022 21:51
@benpicco benpicco requested a review from gschorcht as a code owner December 16, 2022 21:56
@github-actions github-actions bot added the Platform: ESP Platform: This PR/issue effects ESP-based platforms label Dec 16, 2022
@benpicco benpicco force-pushed the cpu/cortexm_common-picolibc branch from 7f216a9 to 46dcea6 Compare December 16, 2022 22:03
@benpicco benpicco requested a review from fjmolinas as a code owner December 16, 2022 22:11
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 16, 2022
@benpicco benpicco force-pushed the cpu/cortexm_common-picolibc branch from d8f2e32 to 3625996 Compare December 16, 2022 22:20
@benpicco benpicco added the CI: full build disable CI build filter label Dec 16, 2022
@benpicco
Copy link
Contributor Author

benpicco commented Dec 16, 2022

bors retry
@benpicco
Copy link
Contributor Author

benpicco commented Dec 16, 2022

Well this will probably fail, but it's the only way to get a full build - so let's give it a try 😈

bors merge
bors bot added a commit that referenced this pull request Dec 16, 2022
@bors @benpicco
Merge #19061
b054eda 
19061: cpu/cortexm_common: use picolibc by default r=benpicco a=benpicco



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

Build failed:
@github-actions github-actions bot added the Area: USB Area: Universal Serial Bus label Dec 16, 2022
@benpicco
Copy link
Contributor Author

benpicco commented Dec 16, 2022

bors merge
@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.
@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

👎 Rejected by PR status
@kaspar030 kaspar030 added CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 19, 2022
@benpicco
Copy link
Contributor Author

benpicco commented Jan 26, 2023

bors try
bors bot added a commit that referenced this pull request Jan 26, 2023
@bors
Try #19061:
a28d97e
@benpicco benpicco removed the CI: full build disable CI build filter label Jan 26, 2023
@bors
Copy link
Contributor

bors bot commented Jan 26, 2023

try

Build failed:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: USB Area: Universal Serial Bus CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms

4 participants

@benpicco @riot-ci @maribu @kaspar030