Skip to content

Fix/window race around #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/window race around #879

wants to merge 2 commits into from

Conversation

@Animesh404
Copy link
Member

@Animesh404 Animesh404 commented Oct 21, 2024

What kind of change does this PR introduce?

a WIP PR for bugfix #816
Summary

  • removed data from WindowEvent model and created a new model A11yEvent which points to the relevant WindowEvent
  • updated crud by adding insert_a11y_event
  • made changes in record where we use queue to map which WindowEvent is waiting for its corresponding A11yEvent
  • added a11y_event in dashboard.

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

Other information
This is still a WIP PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@Animesh404