replace static_assert(false) with host-only THROW #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Replaces compile-time static_assert(false) checks for unimplemented branches with a host-only runtime error (MATX_THROW) guarded by #ifndef __CUDACC__.
- Removed
static_assertfor unimplemented cases and introducedMATX_THROWon host only - Wrapped throws in
#ifndef __CUDACC__to exclude them from device compilation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| include/matx/core/tensor_impl.h | Replaced static_assert with host-only MATX_THROW for unimplemented case |
| include/matx/core/sparse_tensor_format.h | Replaced two static_assert instances with host-only MATX_THROW for unimplemented cases |
Comments suppressed due to low confidence (1)
include/matx/core/tensor_impl.h:945
- [nitpick] The error message "unimplemented case" is generic; consider including context such as function name or branch identifier to aid debugging.
MATX_THROW(matxNotSupported, "unimplemented case");
cliffburdick
approved these changes
May 23, 2025
|
/build |
2 similar comments
|
/build |
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.