Skip to content

Conversation

@MarqRazz
Copy link
Collaborator

This PR adds the option for users to set server_timeout and wait_for_server_timeout through ports specified in the XML file.

@MarqRazz
Copy link
Collaborator Author

MarqRazz commented May 5, 2024

In #60 we have the ability to configure server_timeout and that makes sense to have a global value for wait_for_server_timeout but I still think that users will want the ability to adjust server_timeout per Action/Service. Thoughts?

@MarqRazz MarqRazz requested a review from facontidavide May 5, 2024 14:35
@MarqRazz
Copy link
Collaborator Author

Friendly ping @facontidavide 😄

@b-adkins
Copy link
Contributor

b-adkins commented Jan 4, 2025

In #60 we have the ability to configure server_timeout and that makes sense to have a global value for wait_for_server_timeout but I still think that users will want the ability to adjust server_timeout per Action/Service. Thoughts?

I would find this useful when optimizing bringup. (E.g. for automated full-stack tests.)

We have a behavior tree with a bunch of action clients. Some come up almost immediately, others (e.g. MoveIt) take a little longer.

@rebeccaRossRobotics
Copy link

This would be a really good addition for me. Is there any progress on getting this merged in?

@MarqRazz
Copy link
Collaborator Author

I would be happy to update this if it is something we are considering to merge in. Otherwise I will close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants