From the course: Programming Foundations: Conducting Code Reviews
Unlock the full course today
Join today to access over 24,800 courses taught by industry experts.
Find code reviewers
From the course: Programming Foundations: Conducting Code Reviews
Find code reviewers
- [Instructor] The changes implemented in your pull request is open. Now, you wait for it to be reviewed. You could wait around passively for reviews, and it might get reviewed in a few days, but with some good strategies you can get it approved and merged in no time. On GitHub, you can request reviewers on your PR. When you request another developer, they'll likely receive an email or notification saying that their review has been requested on your pull request. One of the reviewers you request might be the lead of the initiative you are working on. The other might be less familiar with this part of the code base, giving more perspective on the overall big picture. More than two reviewers can often be counterproductive due to conflicting ideas, and it takes too much resource from the overall team. If you use Slack, Microsoft Teams, or another instant messaging platform with your team, you can ping in the appropriate channel that your code is ready for review. You could write…