From the course: Programming Foundations: Conducting Code Reviews
Join today to access over 24,800 courses taught by industry experts.
Approve code
From the course: Programming Foundations: Conducting Code Reviews
Approve code
- [Instructor] Let's check in on the PR we reviewed so we can approve it. It looks like Stephanie addressed some of our comments. Let's see what she changed. We can review the changes from a specific commit or the sum of all of her changes in total associated with this PR. Let's keep this to looking at all of her changes for now, but know that it can be useful to look at each commit individually. She also responded to our comments. For the first comment, she agreed to change the name of the roll dice function, and the new changes show that she's changed the name. The second comment she said, "Good catch. I'll add the plus one." Looking at the implementation, she's done that as well. For the last comment she asked whether we should give an upper limit to the number of die that can be rolled. Looking at the code, she's made the changes to add number of dice as an input and added a check to make sure it's greater than zero. However, as the comment states, she's still unsure whether we…
Download courses and learn on the go
Watch courses on your mobile device without an internet connection. Download courses using your iOS or Android LinkedIn Learning app.