Skip to content

feat: fix bug where blockingpullsubscriber doesn't refill flowcontrol quota. - #449

Merged
jiangmichaellll merged 3 commits into
masterfrom
jiangmichael-spark-refill
Jan 12, 2021
Merged

feat: fix bug where blockingpullsubscriber doesn't refill flowcontrol quota.#449
jiangmichaellll merged 3 commits into
masterfrom
jiangmichael-spark-refill

Conversation

@jiangmichaellll

@jiangmichaellll jiangmichaellll commented Jan 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

As titled.
@jiangmichaellll
jiangmichaellll requested a review from a team January 12, 2021 03:13
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jan 12, 2021
@codecov

codecov Bot commented Jan 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #449 (71f4e36) into master (f484754) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #449      +/-   ##
============================================
+ Coverage     71.06%   71.10%   +0.03%     
+ Complexity      918      917       -1     
============================================
  Files           168      168              
  Lines          4866     4872       +6     
  Branches        244      245       +1     
============================================
+ Hits           3458     3464       +6     
  Misses         1268     1268              
  Partials        140      140
Impacted Files Coverage Δ Complexity Δ
...ubsublite/internal/BlockingPullSubscriberImpl.java 87.93% <100.00%> (+1.39%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f484754...fe3e9b7. Read the comment docs.
@jiangmichaellll
jiangmichaellll merged commit 109bd83 into master Jan 12, 2021
@jiangmichaellll
jiangmichaellll deleted the jiangmichael-spark-refill branch January 12, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

2 participants

@jiangmichaellll @dpcollins-google