Skip to content

fix: Extract the rpc exception from IllegalStateExceptions in publish/… - #430

Merged
palmere-google merged 1 commit into
masterfrom
palmere-vpcsc
Dec 16, 2020
Merged

palmere-google merged 1 commit into
masterfrom
palmere-vpcsc

Conversation

@palmere-google

Copy link
Copy Markdown
Contributor

…subscribe

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@palmere-google
palmere-google requested a review from a team December 16, 2020 18:06
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 16, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2020
@codecov

codecov Bot commented Dec 16, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #430 (e0b06ef) into master (e56d2c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #430   +/-   ##
=========================================
  Coverage     71.60%   71.60%           
  Complexity      877      877           
=========================================
  Files           164      164           
  Lines          4613     4613           
  Branches        233      233           
=========================================
  Hits           3303     3303           
  Misses         1179     1179           
  Partials        131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56d2c2...ea11f06. Read the comment docs.

@palmere-google palmere-google changed the title fix: Extract the rpc exception from IllegalStateExceptins in publish/… Dec 16, 2020
@palmere-google
palmere-google merged commit ff05b1a into master Dec 16, 2020
@palmere-google
palmere-google deleted the palmere-vpcsc branch December 16, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

3 participants