The Wayback Machine - https://web.archive.org/web/20220411142554/https://github.com/Warzone2100/warzone2100/issues/1238
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "building highlighted" appearance to standard selection box #1238

Open
bjorn-ali-goransson opened this issue Oct 25, 2020 · 6 comments · May be fixed by #1255
Open

Change "building highlighted" appearance to standard selection box #1238

bjorn-ali-goransson opened this issue Oct 25, 2020 · 6 comments · May be fixed by #1255
Labels
Feature good first issue

Comments

@bjorn-ali-goransson
Copy link
Contributor

@bjorn-ali-goransson bjorn-ali-goransson commented Oct 25, 2020

Describe the feature you'd like
I'd like to standardize the "selected thing" appearance to what we're currently using for units/droids.

This means we should use the white corners for the selected structures as well, for consistency.

The structure highlight "flash" should perhaps also be disabled (but not mandatory).

Describe why do you think it is needed
Currently the highlighting is not very clear. It is also not at all in the same aesthetic as the standard selection box.

Moreover, the health bar should be sized accordingly, as well.

ezgif-7-dff09d5e7a8b
@berserkingyadis
Copy link
Member

@berserkingyadis berserkingyadis commented Oct 25, 2020

Im not sure I like the pulsing. An outline or encirclement with a color that contrasts well with the ground could be better. Like in some blizz games
selection
@berserkingyadis
Copy link
Member

@berserkingyadis berserkingyadis commented Oct 25, 2020

Mabye we can use what we are using for our units for the buildings aswell. Add these white markers in all 4 corners? Or enclose in rectangle?
image
@thiagorb
Copy link
Member

@thiagorb thiagorb commented Oct 25, 2020

I don't have an opinion on which selection effect to use, highlighting, white corners, or some other.. but I agree that it makes more sense that all selections (building or droids) use the same effect.
@Lupus-Mechanicus
Copy link
Member

@Lupus-Mechanicus Lupus-Mechanicus commented Oct 25, 2020

I agree with Bers proposal for having the same selection effect as the units currently have right now. We could take it one step further and make it so the foundation edges [or the immediate zone after the foundation ends] are highlighted in this way. With the Healthbar showing under it, not right on the building itself.
image
@bjorn-ali-goransson
Copy link
Contributor Author

@bjorn-ali-goransson bjorn-ali-goransson commented Oct 25, 2020

that last suggestion would indeed be awesome, but not feasible in the near future ...
@Lupus-Mechanicus
Copy link
Member

@Lupus-Mechanicus Lupus-Mechanicus commented Oct 25, 2020

that last suggestion would indeed be awesome, but not feasible in the near future ...

Then we stick with the similar unit selection method, applied to buildings as well, for the foreseeable future. 👍
@bjorn-ali-goransson bjorn-ali-goransson added the good first issue label Oct 25, 2020
@bjorn-ali-goransson bjorn-ali-goransson linked a pull request Nov 1, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature good first issue
4 participants
@bjorn-ali-goransson @thiagorb @berserkingyadis @Lupus-Mechanicus