The Wayback Machine - https://web.archive.org/web/20211014223723/https://github.com/mapbox/mapbox-gl-native/issues/11495
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining style classes references #11495

Open
asheemmamoowala opened this issue Mar 21, 2018 · 6 comments
Open

Remove remaining style classes references #11495

asheemmamoowala opened this issue Mar 21, 2018 · 6 comments
Labels
archived good first issue Node.js

Comments

@asheemmamoowala
Copy link
Contributor

@asheemmamoowala asheemmamoowala commented Mar 21, 2018

Carried forward from #11477(comment).

Documentation for style classes still exists in the node bindings in the Readme.

Cod for parsing style classes also lingers in:

mapbox-gl-native/platform/node/src/node_map.cpp

Lines 314 to 321 in 553efa3

if (Nan::Has(obj, Nan::New("classes").ToLocalChecked()).FromJust()) {
auto classes = Nan::To<v8::Object>(Nan::Get(obj, Nan::New("classes").ToLocalChecked()).ToLocalChecked()).ToLocalChecked().As<v8::Array>();
const int length = classes->Length();
options.classes.reserve(length);
for (int i = 0; i < length; i++) {
options.classes.emplace_back(std::string { *Nan::Utf8String(Nan::To<v8::String>(Nan::Get(classes, i).ToLocalChecked()).ToLocalChecked()) });
}
}

Both of these references should be removed. Style classes were removed from the rest of the code base in #8953.
@asheemmamoowala asheemmamoowala mentioned this issue Mar 21, 2018
Closed
@stale
Copy link

@stale stale bot commented Oct 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the archived label Oct 25, 2018
@asheemmamoowala
Copy link
Contributor Author

@asheemmamoowala asheemmamoowala commented Oct 26, 2018

This is still valuable code & doc cleanup that should be done
@stale stale bot removed the archived label Oct 26, 2018
@stale stale bot added the archived label Apr 24, 2019
@stale
Copy link

@stale stale bot commented Apr 24, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.
@stale stale bot closed this Apr 24, 2019
@stale stale bot removed the archived label Apr 25, 2019
@stale stale bot added the archived label Oct 22, 2019
@stale
Copy link

@stale stale bot commented Oct 22, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.
@stale stale bot closed this Oct 22, 2019
@stale stale bot removed the archived label Oct 22, 2019
@stale stale bot added the archived label Apr 19, 2020
@stale
Copy link

@stale stale bot commented Apr 19, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.
@stale stale bot closed this Apr 19, 2020
@alexshalamov alexshalamov reopened this Apr 20, 2020
@stale stale bot removed the archived label Apr 20, 2020
@alexshalamov
Copy link
Contributor

@alexshalamov alexshalamov commented Apr 20, 2020

/cc @springmeyer
@stale stale bot added the archived label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived good first issue Node.js
2 participants
@alexshalamov @asheemmamoowala