[KED-2615] Nudge user to upgrade Kedro-Viz from the CLI #690
+127
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limdauto
reviewed
Jan 10, 2022
| cd package && isort . | ||
| black package/kedro_viz package/tests package/features | ||
| pylint --rcfile=package/.pylintrc -j 0 package/kedro_viz | ||
| pylint --rcfile=package/.pylintrc -j 0 --disable=protected-access,missing-docstring,redefined-outer-name,no-self-use,invalid-name,too-few-public-methods,no-member,unused-argument,duplicate-code package/tests | ||
| pylint --rcfile=package/.pylintrc -j 0 --disable=missing-docstring,no-name-in-module,unused-argument package/features | ||
| flake8 --config=package/.flake8 package | ||
| mypy --config-file=package/mypy.ini package |
There was a problem hiding this comment.
I changed this in another PR to parallelise this step but I didn't know & and wait doesn't work on makefile across serveral lines, so I reverted it here.
limdauto
requested review from
MerelTheisenQB,
rashidakanchwala and
AntonyMilneQB
and removed request for
MerelTheisenQB
|
Do we want to make a note about Kedro-Viz being designed to be backward compatible? |
AntonyMilneQB
approved these changes
Jan 10, 2022
Nice change, and
Just a couple of ideas - nothing big, so feel free to ignore:
- should we explain why a user might want to upgrade? "It's backwards-compatible so will work with your current project straight away and will let you use lots of cool new features"
- is there any way of making it even easier for someone to run the
pip install -Ucommand so they don't even need to copy/paste it? Like somehow making it clickable or so they just type "y" to execute it (this would be annoying though because you get all the kedro viz console messages after that). I think probably not, but just mentioning it in case you are struck with inspiration
|
@AntonyMilneQB @datajoely yea happy to highlight it if someone can help me with the wording. It's already quite long. @AntonyMilneQB re autoupdate: yes, that's the next iteration. This is a quick fix first, then the idea is we do autoupdate like VSCode or even from the CLI. But that's more involved (need to launch and manage another process, etc.) |
Signed-off-by: Lim Hoang <limdauto@gmail.com>
Signed-off-by: Lim Hoang <limdauto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
This PR shows a warning to encourage user to upgrade Kedro-Viz if there is a newer version on PyPI.
Development notes
QA notes
I have tested this manually
Checklist
RELEASE.mdfileThe text was updated successfully, but these errors were encountered: