Improve CI Setup #681
Merged
Improve CI Setup #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynandebold
approved these changes
Jan 5, 2022
Looks good to me. The results speak for themselves. Nice work.
Just one comment about the tools/ci.js file, but I'll approve straight away.
| @@ -51,7 +43,7 @@ commands: | |||
| steps: | |||
| - run: | |||
| name: Install Node dependencies | |||
| command: node tools/ci.js | |||
| command: npm install | |||
There was a problem hiding this comment.
I think we can delete the tools/ci.js file now. Doesn't seem to be used anywhere else.
studioswong
reviewed
Jan 5, 2022
| # Get rid of pyenv stuff | ||
| sudo rm -rf .pyenv/ /opt/circleci/.pyenv/ | ||
| # Download and install miniconda | ||
| curl https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh > miniconda.sh | ||
| bash miniconda.sh -b -p $HOME/miniconda | ||
| # Create an anaconda virtualenv for python ${CONDA_ENV_PY_VERSION} and make that the default python interpreter | ||
| echo ". /home/circleci/miniconda/etc/profile.d/conda.sh" >> $BASH_ENV | ||
| echo "conda deactivate; conda activate kedro-viz" >> $BASH_ENV | ||
| . /home/circleci/miniconda/etc/profile.d/conda.sh | ||
| conda create --name kedro-viz python=${CONDA_ENV_PY_VERSION} -y | ||
| source $BASH_ENV |
There was a problem hiding this comment.
@limdauto this is more for my curiosity - I wonder why won't we need conda as the default python interpreter with the new setup? Is it becuase of the switch to use cimg?
rashidakanchwala
added a commit
that referenced
this issue
Jan 10, 2022
Signed-off-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
rashidakanchwala
added a commit
that referenced
this issue
Jan 11, 2022
Signed-off-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
cimgimage as opposed to the legacycircleci.npm installinstead ofnpm cito allownode_modulescache to take effectmake pylintNet result
Before:
After:
Further improvement
Maybe we can run windows test on main only.
Development notes
QA notes
Checklist
RELEASE.mdfileThe text was updated successfully, but these errors were encountered: