The Wayback Machine - https://web.archive.org/web/20211024183116/https://github.com/gorhill/uBlock/issues/3348
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"create" filter button disabled #3348

Open
mapx- opened this issue Dec 16, 2017 · 2 comments
Open

"create" filter button disabled #3348

mapx- opened this issue Dec 16, 2017 · 2 comments

Comments

@mapx-
Copy link

@mapx- mapx- commented Dec 16, 2017 •
edited

  • windows 10

  • FF 58.0b11 (64-bit) uBo 1.14.21rc4
    or

  • chrome Version 64.0.3282.24 (Official Build) beta (64-bit) uBo dev build 1.14.21.104

  • go to google.com

  • open dashboard, logger

  • refresh page

  • choose some element to block for example:
    notifications.google.com

  • Click on the 4th cell of a log entry => to create a static filter

  • create the filter => ||notifications.google.com

Now refresh the page, go into "my filters" tab, delete the filter.
Repeat exactly the same steps above.
When the filter was created exactly as in the first step => the "Create" button is disabled.

It does not matter which is the test page.
@mapx-
Copy link
Author

@mapx- mapx- commented Dec 17, 2017

probably same root origin:

  • disable "my filters" list
  • use element picker to create a cosmetic filter
  • the filter is written in "my filters" section but should not apply (on refreshing page)
@gorhill
Copy link
Owner

@gorhill gorhill commented Jan 1, 2018 •
edited

Without looking into it, I think I remember keeping a list of the latest filters created through that UI, and disable the create button if there is an attempt to create the same filter again. I did not take into account that the user could delete the filter and re-create again. I need a better approach to prevent creating duplicate filters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@gorhill @mapx-