The Wayback Machine - https://web.archive.org/web/20211017220216/https://github.com/gorhill/uBlock/issues/1940
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dim the 'Ignore generic cosmetic filters' option when appropriate #1940

Open
Gitoffthelawn opened this issue Aug 28, 2016 · 2 comments
Open

Dim the 'Ignore generic cosmetic filters' option when appropriate #1940

Gitoffthelawn opened this issue Aug 28, 2016 · 2 comments

Comments

@Gitoffthelawn
Copy link

@Gitoffthelawn Gitoffthelawn commented Aug 28, 2016

Issue Report Synopsis:

When the Parse and enforce cosmetic filters option is disabled, the Ignore generic cosmetic filters sub-option is not dimmed.

Test Environment:

uBlock Origin version: 1.9.0
Firefox version: 48.0.2 (applies to 32-bit and 64-bit)

Steps To Reproduce:

  1. Disable Parse and enforce cosmetic filters
  2. Notice that Ignore generic cosmetic filters is not dimmed, even though it has no effect.

Expected Behavior:

When Parse and enforce cosmetic filters is disabled (unchecked), the Ignore generic cosmetic filters option should be dimmed.

Recommendation:

Dim the Ignore generic cosmetic filters option when Parse and enforce cosmetic filters is disabled (unchecked).
@Gitoffthelawn Gitoffthelawn mentioned this issue Feb 26, 2017
Open
@gorhill
Copy link
Owner

@gorhill gorhill commented Mar 22, 2017 •
edited

I can't make exceptions for user filters, one single generic cosmetic filter would cause all the expected benefits from using this setting to completely disappear -- it takes only one single generic cosmetic filter to exist for uBO to be forced to survey the DOM of a document. Since the re-factoring of 3rd-party pane, it is no longer displayed as a sub-option, so this is no longer an issue.
@gorhill gorhill closed this Mar 22, 2017
@gorhill
Copy link
Owner

@gorhill gorhill commented Oct 24, 2017

I just had an idea how uBO could disabling DOM surveying while allowing user's own generic cosmetic filters: to simply just inject them all unconditionally. The worry though is that a user would paste a huge amount of generic filters in their My filters pane. Reopening, to assess more thoroughly this implementation idea.
@gorhill gorhill reopened this Oct 24, 2017
@gorhill gorhill mentioned this issue Dec 19, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@gorhill @Gitoffthelawn