The Wayback Machine - https://web.archive.org/web/20240114220743/https://github.com/github/docs/pull/2211
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include 'shell command' as a possible step task #2211

Merged
merged 3 commits into from Jan 18, 2021
Merged

include 'shell command' as a possible step task #2211

merged 3 commits into from Jan 18, 2021

Conversation

qmacro
Copy link
Contributor

@qmacro qmacro commented Dec 18, 2020

Why:

This page helped me greatly to understand all the component parts in GitHub Actions. One thing that is now clear to me is that there are two types of "task" that a step can actually be - either an action, or a shell command. This is explained in a couple of places in this page, but is notably missing in this specific "Understanding the workflow file" section.

I've raised issue #2210 for this, and here's the PR to address it. Thanks.

What's being changed:

  • Old: "Each line nested under this section is a separate action."
  • New: "Each line nested under this section is a separate action or shell command."

Check off the following:
@qmacro
include 'shell command' as a possible step task
062973f 
This page helped me greatly to understand all the component parts in GitHub Actions. One thing that is now clear to me is that there are two types of "task" that a step can actually be - either an action, or a shell command. This is explained in a couple of places in this page, but is notably missing in this "Understanding the workflow file" section.
@welcome
Copy link

welcome bot commented Dec 18, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@janiceilene janiceilene linked an issue Dec 18, 2020 that may be closed by this pull request
'Shell command' as alternative type of task for a step is missing #2210
Closed
@janiceilene
Copy link
Collaborator

@qmacro Thanks so much for opening a PR! I'll get this triaged for review ⚡
@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the docs ecosystem team labels Dec 18, 2020
@janiceilene janiceilene added this to Ecosystem in Docs open source board Dec 18, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 25, 2020
@qmacro
Copy link
Contributor Author

qmacro commented Dec 26, 2020

Adding a comment to give this PR chance to survive the holiday period :)
@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 26, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 2, 2021
@qmacro
Copy link
Contributor Author

qmacro commented Jan 2, 2021

...
@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 3, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 10, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 11, 2021
@jmarlena jmarlena moved this from Ecosystem to Actions in Docs open source board Jan 15, 2021
lucascosti
lucascosti approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stage looks good! I'll merge this when the tests pass.

Thanks again, @qmacro! 🙇‍♂️
@lucascosti lucascosti merged commit 251d79c into github:main Jan 18, 2021
Docs open source board automation moved this from Actions to Done Jan 18, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.
@qmacro qmacro deleted the patch-1 branch January 18, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the docs ecosystem team
4 participants
@qmacro @janiceilene @lucascosti @FAISAILWE23