The Wayback Machine - https://web.archive.org/web/20260107115218/https://github.com/github/codeql/pull/4765
Skip to content

Data flow: Cache ParamUpdateReturnKind::getAnOutNode() #4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hvitved wants to merge 2 commits into from
Closed

Data flow: Cache ParamUpdateReturnKind::getAnOutNode() #4765

hvitved wants to merge 2 commits into from

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Dec 2, 2020 •
edited
Loading

@aschackmull
Copy link
Contributor

aschackmull commented Dec 2, 2020

Why?
@hvitved
Copy link
Contributor Author

hvitved commented Dec 2, 2020

Why?

This removes the only reference to getPreUpdateNode() that would otherwise be computed for each and every data-flow query, which may be expensive in the long run.
@aschackmull
Copy link
Contributor

aschackmull commented Dec 2, 2020

I guess that just shifts my confusion as to why getPreUpdateNode would be expensive. Maybe that is a candidate for caching in the language-specific part if it for some reason is expensive for a single language?
@hvitved hvitved closed this Apr 20, 2021
@hvitved hvitved deleted the dataflow/cache-postupdate-out branch April 20, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# C++ Java Python

2 participants

@hvitved @aschackmull