Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upToo Many Filters (Almost) by Default #93
Comments
|
Which filters have you enabled under "Security"? |
|
@ameshkov For the purposes of this example, all three, namely |
|
Generally, the only way to partly solve this 50k issue is to have multiple content blocker extensions in Safari. The problem with this approach is that filters inside different content blockers cannot affect each other (which is sometimes necessary). So we'll have to do some weird stuff:
|
|
hmm, this sounds interesting |
|
I believe one of the key issues is that it is currently very difficult to understand what should be enabled. For example, in the
If AdGuard “needs a separate filter for Safari,” then what are all the other filters doing? The description implies that anything but this filter is incompatible with Safari and seems to make every other filter in the app useless. Yet, this “made-for-Safari” filter, which ships in an app called “AdGuard for Safari” is hidden in the “Other” section… It is also difficult for anyone not intimately familiar with the various lists to know what extent, if any, they are liable to overlap. For example, Regarding your comment above, I believe this is what the popular 1Blocker extension does on iOS, and it seems to be working very well on that platform. I do not know to what extent it could be translated to macOS, since 1Blocker for macOS is more or less dead in the water, but it seems the approach has been battle-tested in theory at least. |
|
This approach will work indeed, we've implemented it already on iOS (it's in the inner test at the moment). However, most of the filters maintainers don't care about Safari and its limitations, and that's why we should be careful. Regarding the Safari filter, it was supposed to resolve issues caused by Safari content blocking API limitations. Tbh, it is obsolete and will be removed in the future. |
|
@Mizzick we'll need to prepare the Safari converter for that. The task is complicated so it's postponed to 1.3 (at least). |
|
@ameshkov Within AdGuard for Safari I now enabled the IDENTICAL lists (even one less, since I don’t need the 'AdGuard Mobile Ad filter' on my Mac). How can this be that iOS says rules are below 50k and Mac says above? |
|
Moved to 1.4, v1.3 is all about advanced blocking rules: #114 |
|
@maciboy |
|
Is here some progress ? |
|
@F3000 the issue is assigned to the v1.4 |
|
Willl you implemented it like suggested ? |
|
Yes, but later, we're working on v1.3 release right now |
|
Ok . Have you a new state for iOS beta which will include the different plugins ? |
|
@ameshkov Audrey it's not 100% clear to me, please could you confirm if 1.4 will support >50,000 filters? The thread seems slightly ambiguous in that it might refer to "resolving differences between iOS & macOS" You see right now users of uBlock-Origin cannot proceed on Safari Technical Preview 80 and are therefore forced to change to alternative adblockers. Since most uBlock-Origin users typically require more than 50k filters, AdGuard is effectively out of the running, save for that critical (comment you made regarding v1.4 which I might have misunderstood). In the meantime, several users have already migrated to a number of platforms and are starting to report back. Keep it up, very impressive work here! |
I guess this one, by adding multiple content blocking extensions to Safari (supposedly, 50k rules limitation will refer to each extension). See #93 (comment) .
only ragards multiple content blocking extensions support
For now the issue is assigned to the v1.4 . PS: |
|
Well , I have deactivated everything but 1 filter which its ad blocking and still says "too many filters" |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Steps to reproduce
Expected behavior
AdGuard should enable the filters it can use and let me know what filters cannot be enabled and why.
AdGuard should suggest a sane default configuration comprised of optimal filters for ad-blocking and/or security. If users cannot enable ad blocking and security at the same time, then AdGuard should explain why and let them choose.
Actual behavior
AdGuard complains that I have gone over the 50 000 Filters limit, even though I only used obvious toggles to enable filters that any user of a Safari Content Blocker can legitimately be interested in.
It is one thing for AdGuard to give users options, but it is quite another to encourage users to shoot themselves in the foot. The current toggle-based system encourages users to enable everything for maximum protection, and forces them into a wall.
It is currently not clear what the best or default configuration is or should be. This leaves users un-checking filters at random until they get below 50 000, without any real sense of whether they are making progress towards a secure configuration.
Your environment
Edited to reply to @ameshkov’s question.