The Wayback Machine - https://web.archive.org/web/20260503145248/https://github.com/angular/angular-cli/pull/19048
Skip to content

feat(@schematics/angular): add generation for resolvers#19048

Merged
alan-agius4 merged 1 commit intoangular:masterfrom
Jefiozie:feature_schematic_resolver
Oct 15, 2020
Merged

feat(@schematics/angular): add generation for resolvers#19048
alan-agius4 merged 1 commit intoangular:masterfrom
Jefiozie:feature_schematic_resolver

Conversation

@Jefiozie
Copy link
Copy Markdown
Contributor

@Jefiozie Jefiozie commented Oct 11, 2020

This will add the resolvers as an option to generate.
You can use it by ng g r <name> or ng generate resolver <name>

closes: #17569
@google-cla google-cla Bot added the cla: yes label Oct 11, 2020
@Jefiozie
Copy link
Copy Markdown
Contributor Author

Jefiozie commented Oct 12, 2020

Just referencing @alan-agius4 or @clydin for reviewing 😄
@kyliau kyliau added the needs: discussion On the agenda for team meeting to determine next steps label Oct 12, 2020
alan-agius4
alan-agius4 requested changes Oct 12, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, one small NIT.
Comment thread packages/schematics/angular/resolver/schema.json Outdated
Comment thread packages/schematics/angular/resolver/index.ts Outdated
Comment thread packages/schematics/angular/resolver/index.ts Outdated
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: major This PR is targeted for the next major release and removed needs: discussion On the agenda for team meeting to determine next steps labels Oct 12, 2020
alan-agius4
alan-agius4 reviewed Oct 13, 2020
View reviewed changes
Comment thread packages/schematics/angular/resolver/schema.json Outdated
@Jefiozie
Copy link
Copy Markdown
Contributor Author

Jefiozie commented Oct 13, 2020

Will make these changes as soon as i have some time.
@Jefiozie Jefiozie force-pushed the feature_schematic_resolver branch from 0d8bce4 to 29bab8c Compare October 14, 2020 05:49
@Jefiozie
Copy link
Copy Markdown
Contributor Author

Jefiozie commented Oct 14, 2020

Hey @alan-agius4, I have changed your comments, I think it is good to do a quick review again. Thanks for your comments.
@Jefiozie Jefiozie force-pushed the feature_schematic_resolver branch from 29bab8c to d2d274f Compare October 14, 2020 05:58
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 14, 2020
@alan-agius4
Copy link
Copy Markdown
Collaborator

alan-agius4 commented Oct 14, 2020

Thanks for your contribution @Jefiozie.
@Jefiozie
Copy link
Copy Markdown
Contributor Author

Jefiozie commented Oct 14, 2020

Thank you, hope to do some more contributions.
@alan-agius4 alan-agius4 merged commit 45c0b50 into angular:master Oct 15, 2020
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Nov 15, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 15, 2020
@Jefiozie Jefiozie deleted the feature_schematic_resolver branch October 27, 2024 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

3 participants

@Jefiozie @alan-agius4 @kyliau