The Wayback Machine - https://web.archive.org/web/20210128124141/https://github.com/php/php-src/pull/4884
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept int parameter in the first place #4884

Closed
wants to merge 1 commit into from

Conversation

@cmb69
Copy link
Contributor

@cmb69 cmb69 commented Nov 1, 2019

This is more liberal then before, where that parameter (if given) had
to be IS_LONG, while now it would be converted to int according to weak
typing rules. This is, however, more what a developer would expect.

This is more liberal then before, where that parameter (if given) had
to be IS_LONG, while now it would be converted to int according to weak
typing rules.  This is, however, more what a developer would expect.
@nikic
nikic approved these changes Nov 1, 2019
@cmb69
Copy link
Contributor Author

@cmb69 cmb69 commented Nov 1, 2019

Applied as 34defbb. Thanks.

@cmb69 cmb69 closed this Nov 1, 2019
@cmb69 cmb69 deleted the cmb69:openssl_spki_new-int branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants