Manually update the dependencies.props and move S.P.Corelib to use La…

…ngVersion=8.0 (#22452) * Update BuildTools to preview1-03713-01 (master) * Updating CoreCLR to use LangVersion=8.0 * Moving the Windows scripts to default to `dotnet msbuild` for managed components * Setting UseSharedCompilation=true * Changing some additional callsites that were using msbuild to use dotnet msbuild * Revert packages.builds to use Desktop msbuild on Windows * Fixing runtest.cmd to always set DotNetCli
dotnet · Feb 15, 2019 · cd9831cd00408db60364f367756de296852467ae · cd9831c
1 parent bae641f
commit cd9831cd00408db60364f367756de296852467ae
diff --git a/BuildToolsVersion.txt b/BuildToolsVersion.txt
@@ -1 +1 @@
-  
-3.0.0-preview1-03617-02
+  
+3.0.0-preview1-03713-01
diff --git a/UpdatePublishedVersions.ps1 b/UpdatePublishedVersions.ps1
@@ -16,8 +16,8 @@ param(
    # A pattern matching all packages in the set that the versions repository should be set to.
    [Parameter(Mandatory=$true)][string]$nupkgPath)
-  
-& "$PSScriptRoot\msbuild.cmd" /nologo /verbosity:minimal /clp:Summary /nodeReuse:false `
-  
-    /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log `
+  
+& "$PSScriptRoot\dotnet.cmd" msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false `
+  
+    /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log `
    /p:RestoreDefaultOptimizationDataPackage=false `
    /p:PortableBuild=true `
    /p:UsePartialNGENOptimization=false `

diff --git a/build-packages.cmd b/build-packages.cmd
@@ -33,9 +33,9 @@ if [!processedArgs!]==[] (
 :ArgsDone
-  
-call %__ProjectDir%/msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+call %__ProjectDir%/dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
  /p:__BuildOS=Windows_NT /flp:v=detailed;Append;LogFile=build-packages.log^
-  
-  /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+  /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
  /p:PortableBuild=true %__ProjectDir%\src\.nuget\packages.builds^
  /p:FilterToOSGroup=Windows_NT %__MSBuildArgs% %unprocessedArgs%
 if NOT [!ERRORLEVEL!]==[0] (

diff --git a/build-packages.sh b/build-packages.sh
@@ -149,7 +149,7 @@ $__ProjectRoot/dotnet.sh msbuild /nologo /verbosity:minimal /clp:Summary \
                         /p:__BuildOS=$__BuildOS /flp:v=detailed\;Append\;LogFile=build-packages.log \
                         /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll\;LogFile=binclash.log \
                         /p:PortableBuild=true src/.nuget/packages.builds \
-  
-                         /p:__DistroRid=$__DistroRid /p:UseSharedCompilation=false /p:BuildNugetPackage=false \
+  
+                         /p:__DistroRid=$__DistroRid /p:BuildNugetPackage=false \
                         $buildArgs $unprocessedBuildArgs
 if [ $? -ne 0 ]
 then

diff --git a/build-test.cmd b/build-test.cmd
@@ -179,11 +179,6 @@ call "%__ProjectDir%\init-tools.cmd"
 @if defined _echo @echo on
 set "__ToolsDir=%__ProjectDir%\Tools"
-  
-set "DotNetCli=%__ToolsDir%\dotnetcli\dotnet.exe"
-  
-if not exist "%DotNetCli%" (
-  
-    echo %__MsgPrefix%"%DotNetCli%" not found after init-tools.
-  
-    exit /b 1
-  
-)
 REM =========================================================================================
 REM ===
@@ -277,8 +272,8 @@ set __MsbuildWrn=/flp1:WarningsOnly;LogFile="%__BuildWrn%"
 set __MsbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%"
 set __Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr!
-  
-call "%__ProjectDir%\msbuild.cmd" /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
-  
-  /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+call "%__ProjectDir%\dotnet.cmd" msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+  /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
  /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
  /p:UsePartialNGENOptimization=false /maxcpucount^
  %__ProjectDir%\tests\build.proj /t:BatchRestorePackages^
@@ -297,8 +292,8 @@ set __MsbuildWrn=/flp1:WarningsOnly;LogFile="%__BuildWrn%"
 set __MsbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%"
 set __Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr!
-  
-call "%__ProjectDir%\msbuild.cmd" /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
-  
-  /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+call "%__ProjectDir%\dotnet.cmd" msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+  /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
  /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
  /p:UsePartialNGENOptimization=false /maxcpucount^
  %__Projectdir%\tests\runtest.proj /t:BinPlaceRef /t:BinPlaceProduct /t:CopyCrossgenToProduct /p:RuntimeId="%__RuntimeId%"^
@@ -353,7 +348,7 @@ for /l %%G in (1, 1, %__BuildLoopCount%) do (
    set TestBuildSlice=%%G
    echo Running: msbuild %__ProjectDir%\tests\build.proj !__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! %TargetsWindowsMsbuildArg% %__msbuildArgs% %__BuildAgainstPackagesArg% !__PriorityArg! %__UnprocessedBuildArgs%
-  
-    call msbuild %__ProjectDir%\tests\build.proj !__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! %TargetsWindowsMsbuildArg% %__msbuildArgs% %__BuildAgainstPackagesArg% !__PriorityArg! %__UnprocessedBuildArgs%
+  
+    call "%__ProjectDir%\dotnet.cmd" msbuild %__ProjectDir%\tests\build.proj !__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! %TargetsWindowsMsbuildArg% %__msbuildArgs% %__BuildAgainstPackagesArg% !__PriorityArg! %__UnprocessedBuildArgs%
    if errorlevel 1 (
        echo %__MsgPrefix%Error: build failed. Refer to the build log files for details:
@@ -374,8 +369,8 @@ for /l %%G in (1, 1, %__BuildLoopCount%) do (
 REM Check that we've built about as many tests as we expect. This is primarily intended to prevent accidental changes that cause us to build
 REM drastically fewer Pri-1 tests than expected.
 echo %__MsgPrefix%Check the managed tests build
-  
-echo Running: msbuild %__ProjectDir%\tests\runtest.proj /t:CheckTestBuild /p:CLRTestPriorityToBuild=%__Priority% %__msbuildArgs% %__unprocessedBuildArgs%
-  
-call msbuild %__ProjectDir%\tests\runtest.proj /t:CheckTestBuild /p:CLRTestPriorityToBuild=%__Priority% %__msbuildArgs% %__unprocessedBuildArgs%
+  
+echo Running: dotnet msbuild %__ProjectDir%\tests\runtest.proj /t:CheckTestBuild /p:CLRTestPriorityToBuild=%__Priority% %__msbuildArgs% %__unprocessedBuildArgs%
+  
+call "%__ProjectDir%\dotnet.cmd" msbuild %__ProjectDir%\tests\runtest.proj /t:CheckTestBuild /p:CLRTestPriorityToBuild=%__Priority% %__msbuildArgs% %__unprocessedBuildArgs%
 if errorlevel 1 (
    echo %__MsgPrefix%Error: build failed.
    exit /b 1
@@ -438,8 +433,8 @@ set __MsbuildWrn=/flp1:WarningsOnly;LogFile="%__BuildWrn%"
 set __MsbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%"
 set __Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr!
-  
-call %__ProjectDir%\msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
-  
-  /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+call %__ProjectDir%\dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+  /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
  /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
  /p:UsePartialNGENOptimization=false /maxcpucount^
  %__ProjectDir%\tests\runtest.proj /t:CreateTestOverlay^
@@ -472,8 +467,8 @@ set __MsbuildWrn=/flp1:WarningsOnly;LogFile="%__BuildWrn%"
 set __MsbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%"
 set __Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr!
-  
-call %__ProjectDir%\msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
-  
-  /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+call %__ProjectDir%\dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+  /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
  /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
  /p:UsePartialNGENOptimization=false /maxcpucount^
  %__ProjectDir%\tests\runtest.proj /t:CreateTestHost^
@@ -506,7 +501,7 @@ set __MsbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%"
 set __Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr!
 REM Build wrappers using the local SDK's msbuild. As we move to arcade, the other builds should be moved away from run.exe as well.
-  
-call %DotNetCli% msbuild %__ProjectDir%\tests\runtest.proj /p:RestoreAdditionalProjectSources=https://dotnet.myget.org/F/dotnet-core/  /p:BuildWrappers=true !__Logging! %__msbuildArgs% %TargetsWindowsMsbuildArg% %__BuildAgainstPackagesArg% %__UnprocessedBuildArgs%
+  
+call "%__ProjectDir%\dotnet.cmd" msbuild %__ProjectDir%\tests\runtest.proj /p:RestoreAdditionalProjectSources=https://dotnet.myget.org/F/dotnet-core/  /p:BuildWrappers=true !__Logging! %__msbuildArgs% %TargetsWindowsMsbuildArg% %__BuildAgainstPackagesArg% %__UnprocessedBuildArgs%
 if errorlevel 1 (
    echo %__MsgPrefix%Error: Xunit wrapper build failed. Refer to the build log files for details:
    echo     %__BuildLog%
@@ -557,8 +552,8 @@ set __MsbuildWrn=/flp1:WarningsOnly;LogFile="%__BuildWrn%"
 set __MsbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%"
 set __Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr!
-  
-call %__ProjectDir%\msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
-  
-  /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+call %__ProjectDir%\dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+  /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
  /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
  /p:UsePartialNGENOptimization=false /maxcpucount^
  %__ProjectDir%\tests\helixprep.proj^

diff --git a/build.cmd b/build.cmd
@@ -367,8 +367,8 @@ REM ============================================================================
 @if defined _echo @echo on
-  
-call %__ProjectDir%\msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
-  
-  /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+call %__ProjectDir%\dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+  /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
  /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
  /p:UsePartialNGENOptimization=false /maxcpucount^
  %__ProjectDir%\build.proj /t:GenerateVersionHeader /p:GenerateVersionHeader=true /p:NativeVersionHeaderFile="%__RootBinDir%\obj\_version.h"^
@@ -382,7 +382,7 @@ REM ============================================================================
 if %__RestoreOptData% EQU 1 (
    echo %__MsgPrefix%Restoring the OptimizationData Package
-  
-    call %__ProjectDir%\msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+    call %__ProjectDir%\dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
      /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
      /p:UsePartialNGENOptimization=false /maxcpucount^
      ./build.proj /t:RestoreOptData^
@@ -394,16 +394,11 @@ if %__RestoreOptData% EQU 1 (
 )
 REM Parse the optdata package versions out of msbuild so that we can pass them on to CMake
-  
-set DotNetCli=%__ProjectDir%\Tools\dotnetcli\dotnet.exe
-  
-if not exist "%DotNetCli%" (
-  
-    echo %__MsgPrefix%Error: "%DotNetCli%" not found
-  
-    exit /b 1
-  
-)
 set OptDataProjectFilePath=%__ProjectDir%\src\.nuget\optdata\optdata.csproj
-  
-for /f "tokens=*" %%s in ('%DotNetCli% msbuild "%OptDataProjectFilePath%" /t:DumpPgoDataPackageVersion /nologo') do (
+  
+for /f "tokens=*" %%s in ('call "%__ProjectDir%\dotnet.cmd" msbuild "%OptDataProjectFilePath%" /t:DumpPgoDataPackageVersion /nologo') do (
    set __PgoOptDataVersion=%%s
 )
-  
-for /f "tokens=*" %%s in ('%DotNetCli% msbuild "%OptDataProjectFilePath%" /t:DumpIbcDataPackageVersion /nologo') do (
+  
+for /f "tokens=*" %%s in ('call "%__ProjectDir%\dotnet.cmd" msbuild "%OptDataProjectFilePath%" /t:DumpIbcDataPackageVersion /nologo') do (
    set __IbcOptDataVersion=%%s
 )
@@ -655,8 +650,8 @@ if %__BuildCoreLib% EQU 1 (
        set __MsbuildErr=/flp2:ErrorsOnly;LogFile=!__BuildErr!
        set __Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr!
-  
-        call %__ProjectDir%\msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
-  
-          /l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
+  
+        call %__ProjectDir%\dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false^
+  
+          /l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log^
          /p:RestoreDefaultOptimizationDataPackage=false /p:PortableBuild=true^
          /p:UsePartialNGENOptimization=false /maxcpucount^
          %__ProjectDir%\build.proj^
@@ -673,7 +668,7 @@ if %__BuildCoreLib% EQU 1 (
    if %__IbcOptimize% EQU 1 (
        echo %__MsgPrefix%Commencing IBCMerge of System.Private.CoreLib for %__BuildOS%.%__BuildArch%.%__BuildType%
        set IbcMergeProjectFilePath=%__ProjectDir%\src\.nuget\optdata\ibcmerge.csproj
-  
-        for /f "tokens=*" %%s in ('%DotNetCli% msbuild "!IbcMergeProjectFilePath!" /t:DumpIbcMergePackageVersion /nologo') do @(
+  
+        for /f "tokens=*" %%s in ('call "%__ProjectDir%\dotnet.cmd" msbuild "!IbcMergeProjectFilePath!" /t:DumpIbcMergePackageVersion /nologo') do @(
            set __IbcMergeVersion=%%s
        )

diff --git a/build.sh b/build.sh
@@ -488,7 +488,7 @@ build_CoreLib()
                             /p:UsePartialNGENOptimization=false /maxcpucount \
                             $__ProjectDir/build.proj \
                             /flp:Verbosity=normal\;LogFile=$__LogsDir/System.Private.CoreLib_$__BuildOS__$__BuildArch__$__BuildType.log \
-  
-                             /p:__IntermediatesDir=$__IntermediatesDir /p:__RootBinDir=$__RootBinDir /p:BuildNugetPackage=false /p:UseSharedCompilation=false \
+  
+                             /p:__IntermediatesDir=$__IntermediatesDir /p:__RootBinDir=$__RootBinDir /p:BuildNugetPackage=false \
                             $__CommonMSBuildArgs $__ExtraBuildArgs $__UnprocessedBuildArgs
    if [ $? -ne 0 ]; then
@@ -552,7 +552,7 @@ generate_NugetPackages()
                             /p:UsePartialNGENOptimization=false /maxcpucount \
                             $__SourceDir/.nuget/packages.builds \
                             /flp:Verbosity=normal\;LogFile=$__LogsDir/Nuget_$__BuildOS__$__BuildArch__$__BuildType.log \
-  
-                             /p:__IntermediatesDir=$__IntermediatesDir /p:__RootBinDir=$__RootBinDir /p:BuildNugetPackages=false /p:UseSharedCompilation=false /p:__DoCrossArchBuild=$__CrossBuild \
+  
+                             /p:__IntermediatesDir=$__IntermediatesDir /p:__RootBinDir=$__RootBinDir /p:BuildNugetPackages=false /p:__DoCrossArchBuild=$__CrossBuild \
                             $__CommonMSBuildArgs $__UnprocessedBuildArgs
    if [ $? -ne 0 ]; then

diff --git a/clean.cmd b/clean.cmd
@@ -30,7 +30,7 @@ if [%1]==[] set __args=/t:CleanAllProjects
 if [%1]==[-b] set __args=/t:CleanAllProjects
 if [%1]==[-p] set __args=/t:CleanPackages
 if [%1]==[-c] set __args=/t:CleanPackagesCache
-  
-call %~dp0msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false /flp:v=normal;LogFile=clean.log %__args%
+  
+call %~dp0dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false /flp:v=normal;LogFile=clean.log %__args%
 exit /b %ERRORLEVEL%
 :Usage
@@ -44,4 +44,4 @@ echo     -c     - Deletes the user-local NuGet package cache.
 echo     -all   - Cleans repository and restores it to pristine state.
 echo.
 echo ^If no option is specified then "clean -b" is implied.
-  
-exit /b
+  
+exit /b
diff --git a/dependencies.props b/dependencies.props
@@ -26,7 +26,7 @@
  <!-- Source of truth for dependency tooling: the commit hash of the dotnet/versions master branch as of the last auto-upgrade. -->
  <PropertyGroup>
    <CoreClrCurrentRef>f31086500dc58cefe7b1275300f6fc07b38c1bcc</CoreClrCurrentRef>
-  
-    <BuildToolsCurrentRef>f31086500dc58cefe7b1275300f6fc07b38c1bcc</BuildToolsCurrentRef>
+  
+    <BuildToolsCurrentRef>caae3bdca7852cd19b259bdc9749ccdcea9fe761</BuildToolsCurrentRef>
    <PgoDataCurrentRef>7fb04b947ac4fde6e33a57474c5c4a07ef90a185</PgoDataCurrentRef>
    <IbcDataCurrentRef>7fb04b947ac4fde6e33a57474c5c4a07ef90a185</IbcDataCurrentRef>
  </PropertyGroup>
@@ -51,7 +51,7 @@
  <!-- Package versions used as toolsets -->
  <PropertyGroup>
    <FeedTasksPackage>Microsoft.DotNet.Build.Tasks.Feed</FeedTasksPackage>
-  
-    <FeedTasksPackageVersion>3.0.0-preview1-03617-02</FeedTasksPackageVersion>
+  
+    <FeedTasksPackageVersion>3.0.0-preview1-03713-01</FeedTasksPackageVersion>
  </PropertyGroup>
  <!-- Publish symbol build task package -->

diff --git a/dir.props b/dir.props
@@ -4,6 +4,11 @@
  <Import Project="dir.common.props" />
+  
+  <PropertyGroup>
+  
+    <LangVersion>8.0</LangVersion>
+  
+    <UseSharedCompilation>true</UseSharedCompilation>
+  
+  </PropertyGroup>
+  
+
  <!--
    $(OS) is set to Unix/Windows_NT. This comes from an environment variable on Windows and MSBuild on Unix.
  -->
@@ -24,19 +29,13 @@
    <MinorVersion>6</MinorVersion>
  </PropertyGroup>
-  
-  <!-- Build Tools Versions -->
-  
-  <PropertyGroup>
-  
-    <RoslynVersion>1.0.0-rc3-20150510-01</RoslynVersion>
-  
-    <RoslynPackageName>Microsoft.Net.ToolsetCompilers</RoslynPackageName>
-  
-  </PropertyGroup>
-  
-
  <!--
     Switching to the .NET Core version of the BuildTools tasks seems to break numerous scenarios, such as VS intellisense and resource designer
     as well as running the build on mono. Until we can get these sorted out we will continue using the .NET 4.5 version of the tasks.
     -->
  <PropertyGroup>
    <RunningOnCore>false</RunningOnCore>
-  
-    <RunningOnCore Condition="'$(MSBuildRuntimeType)' == 'Core'">true</RunningOnCore>
+  
+    <RunningOnCore Condition="'$(MSBuildRuntimeType)' == 'core'">true</RunningOnCore>
    <BuildToolsTargetsDesktop>false</BuildToolsTargetsDesktop>
    <BuildToolsTargetsDesktop Condition="'$(RunningOnCore)' != 'true'">true</BuildToolsTargetsDesktop>
    <BuildToolsTargets45>$(BuildToolsTargetsDesktop)</BuildToolsTargets45>
@@ -145,10 +144,10 @@
    <ProjectUrl>https://dot.net</ProjectUrl>
-  
-    <!-- On Windows, MSbuild still runs against Desktop FX while it runs on .NET Core on non-Windows. this requires
+  
+    <!-- On Windows, MSbuild can still run against Desktop FX while it runs on .NET Core on non-Windows. this requires
         pulling in different packaging dependencies.
     -->
-  
-    <PackagingTaskDir Condition="'$(TargetsWindows)' == 'true'">$(ToolsDir)net46/</PackagingTaskDir>
+  
+    <PackagingTaskDir Condition="'$(MSBuildRuntimeType)' != 'core'">$(ToolsDir)net46/</PackagingTaskDir>
    <!-- defined in buildtools packaging.targets, but we need this before targets are imported -->
    <PackagePlatform Condition="'$(PackagePlatform)' == ''">$(Platform)</PackagePlatform>
    <PackagePlatform Condition="'$(PackagePlatform)' == 'amd64'">x64</PackagePlatform>
@@ -187,6 +186,5 @@
  </ItemGroup>
  <!-- Use Roslyn Compilers to build -->
-  
-  <Import Project="$(RoslynPropsFile)" Condition="'$(RunningOnUnix)'!='true' and Exists('$(RoslynPropsFile)') and '$(UseRoslynCompilers)'!='false' and '$(RoslynIncompatibleMsbuildVersion)' != 'true'" />
-  
-  <Import Project="$(RoslynPropsFile)" Condition="'$(RunningOnUnix)'=='true' and Exists('$(RoslynPropsFile)') and '$(RoslynIncompatibleMsbuildVersion)' != 'true'" />
+  
+  <Import Project="$(RoslynPropsFile)" />
 </Project>
diff --git a/dotnet.cmd b/dotnet.cmd
@@ -0,0 +1,30 @@
+  
+@if not defined _echo @echo off
+  
+setlocal
+  
+
+  
+set "__ProjectDir=%~dp0"
+  
+
+  
+call "%__ProjectDir%"\setup_vs_tools.cmd
+  
+
+  
+REM setup_vs_tools.cmd will correctly echo error message.
+  
+if NOT '%ERRORLEVEL%' == '0' exit /b 1
+  
+
+  
+:: Clear the 'Platform' env variable for this session, as it's a per-project setting within the build, and
+  
+:: misleading value (such as 'MCD' in HP PCs) may lead to build breakage (issue: #69).
+  
+set Platform=
+  
+set __ProjectDir=
+  
+
+  
+:: Restore the Tools directory
+  
+call %~dp0init-tools.cmd
+  
+if NOT [%ERRORLEVEL%]==[0] (
+  
+  exit /b 1
+  
+)
+  
+
+  
+pushd %~dp0
+  
+echo Running: dotnet %*
+  
+call "%~dp0\Tools\dotnetcli\dotnet.exe" %*
+  
+popd
+  
+if NOT [%ERRORLEVEL%]==[0] (
+  
+  exit /b 1
+  
+)
+  
+
+  
+exit /b 0
diff --git a/publish-packages.cmd b/publish-packages.cmd
@@ -35,7 +35,7 @@ FOR /f "tokens=1*" %%x IN ("%*") DO (
 :ArgsDone
-  
-call %~dp0msbuild.cmd /nologo /verbosity:minimal /clp:Summary /nodeReuse:false /p:__BuildOS=Windows_NT^
+  
+call %~dp0dotnet.cmd msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false /p:__BuildOS=Windows_NT^
  .\src\publish.proj^
  /flp:v=detailed;LogFile=publish-packages.log /clp:v=detailed %__MSBuildArgs%
 @exit /b %ERRORLEVEL%
@@ -57,4 +57,4 @@ echo To specify the name of the container to publish into, use the following pro
 echo   -Container="container name"
 echo Architecture can be x64, x86, arm, or arm64
 echo Configuration can be Release, Debug, or Checked
-  
-exit /b
+  
+exit /b