Camo Everything #96

Merged
merged 2 commits into from Jan 9, 2014

Conversation

3 participants
@josh
Contributor

josh commented Jan 9, 2014

Camo's all images including https.

Removed http/https://github.com image rewriting. Those shouldn't but linked to in GFM. So no one ought to be doing that. They should be using github helpers so they point to our CDN. Also, this would point them to a CDN through camo. Fewer edge cases.

/cc @jch @atmos

@jch

This comment has been minimized.

Show comment Hide comment
@jch

jch Jan 9, 2014

Owner

👍 looks good to me. I'll merge and cut a new release unless someone has more feedback.

Owner

jch commented Jan 9, 2014

👍 looks good to me. I'll merge and cut a new release unless someone has more feedback.

@josh

This comment has been minimized.

Show comment Hide comment
@josh

josh Jan 9, 2014

Contributor

(noting that I don't have commit access to merge myself)

Contributor

josh commented Jan 9, 2014

(noting that I don't have commit access to merge myself)

@jch

This comment has been minimized.

Show comment Hide comment
@jch

jch Jan 9, 2014

Owner

@josh added as a collaborator!

Owner

jch commented Jan 9, 2014

@josh added as a collaborator!

@josh

This comment has been minimized.

Show comment Hide comment
@josh

josh Jan 9, 2014

Contributor

Haha, I didn't need commit, but thanks. I'll let you manage the release.

Contributor

josh commented Jan 9, 2014

Haha, I didn't need commit, but thanks. I'll let you manage the release.

josh added a commit that referenced this pull request Jan 9, 2014

@josh josh merged commit 444b89c into jch:master Jan 9, 2014

@josh josh deleted the josh:camo-everything branch Jan 9, 2014

@jch jch referenced this pull request Jan 9, 2014

Merged

Bump version 1.2.0 #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment