Skip to content

Adding aframe-voice-command-component #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2016
Merged

Adding aframe-voice-command-component #40

merged 2 commits into from
Dec 30, 2016

Conversation

@lmalave
Copy link
Contributor

@lmalave lmalave commented Dec 27, 2016

@ngokevin
Copy link
Member

ngokevin commented Dec 30, 2016

Awesome! I filed some suggestion issues:

lmalave/aframe-voice-command-component#2

lmalave/aframe-voice-command-component#3

lmalave/aframe-voice-command-component#4

lmalave/aframe-voice-command-component#5
@lmalave
Copy link
Contributor Author

lmalave commented Dec 30, 2016

Thanks for the feedback! I renamed the component to aframe-speech-command-component and addressed the other 3 issues that you mentioned in the new repo that is now at:

https://github.com/lmalave/aframe-speech-command-component
@ngokevin
Copy link
Member

ngokevin commented Dec 30, 2016

Awesome! You can also link to your GitHub pages in the GitHub description (at the top).
@ngokevin ngokevin merged commit efc386d into aframevr:master Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@lmalave @ngokevin