fix: proxy html path should be encoded #15223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #13581, the htmlProxy URLs were unencoded. This PR reverts this change, still fixing the linked bugs (there was a test added in that PR).
I tried two approaches, the second commit has the keys in the proxy HTML cache decoded. I think this is the simpler of the two.
There was also an issue when pre-transforming requests in index HTML middleware, the URLs sent to
warmupRequest
should be decoded. Once I did the fix, the ssr-deps playground started to fail for this reason. I added the decoding logic there too.What is the purpose of this pull request?