Skip to content

fix(hmr): ignore non-js modules #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix(hmr): ignore non-js modules #625

merged 1 commit into from
Jul 28, 2025

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 10, 2025 •
edited
Loading

Description

This plugin only handles js module nodes so this plugin should not filter out non-js modules nodes.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
@sapphi-red sapphi-red added feat: hmr p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) labels Jul 10, 2025
@sapphi-red sapphi-red mentioned this pull request Jul 10, 2025
Merged
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@625

npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@625

commit: 81c153a
@sapphi-red sapphi-red merged commit f899ad3 into main Jul 28, 2025
19 checks passed
@sapphi-red sapphi-red deleted the fix/hmr-ignore-non-js-modules branch July 28, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
1 participant
@sapphi-red