refactor: change minUsagePadding from var to const #2325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Collaborator
|
The linter failure is unrelated. I will open a PR to fix it. However I do not have permissions to force a merge for this PR until CI passes. I'll reach out for a rebase when the issue is fixed. |
Contributor
Author
|
sure @marckhouzam |
Collaborator
ssam18
force-pushed
the
refactor/minUsagePadding-constant
branch
from
0ef8e18 to
0a59262
Compare
Contributor
Author
|
Hi @marckhouzam! I've rebased the PR on top of the latest main branch. The linter fix from #2327 is now included, and the branch should be ready to merge. Thanks for your patience |
arthurzam
pushed a commit
to gentoo-golang-dist/forgejo-runner
that referenced
this pull request
Jan 18, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/spf13/cobra](https://github.com/spf13/cobra) | `v1.10.1` -> `v1.10.2` |  |  | --- ### Release Notes <details> <summary>spf13/cobra (github.com/spf13/cobra)</summary> ### [`v1.10.2`](https://github.com/spf13/cobra/releases/tag/v1.10.2) [Compare Source](spf13/cobra@v1.10.1...v1.10.2) #### 🔧 Dependencies - chore: Migrate from `gopkg.in/yaml.v3` to `go.yaml.in/yaml/v3` by [@​dims](https://github.com/dims) in [#​2336](spf13/cobra#2336) - the `gopkg.in/yaml.v3` package has been deprecated for some time: this should significantly cleanup dependency/supply-chains for consumers of `spf13/cobra` #### 📈 CI/CD - Fix linter and allow CI to pass by [@​marckhouzam](https://github.com/marckhouzam) in [#​2327](spf13/cobra#2327) - fix: actions/setup-go v6 by [@​jpmcb](https://github.com/jpmcb) in [#​2337](spf13/cobra#2337) #### 🔥✍🏼 Docs - Add documentation for repeated flags functionality by [@​rvergis](https://github.com/rvergis) in [#​2316](spf13/cobra#2316) #### 🍂 Refactors - refactor: replace several vars with consts by [@​htoyoda18](https://github.com/htoyoda18) in [#​2328](spf13/cobra#2328) - refactor: change minUsagePadding from var to const by [@​ssam18](https://github.com/ssam18) in [#​2325](spf13/cobra#2325) #### 🤗 New Contributors - [@​rvergis](https://github.com/rvergis) made their first contribution in [#​2316](spf13/cobra#2316) - [@​htoyoda18](https://github.com/htoyoda18) made their first contribution in [#​2328](spf13/cobra#2328) - [@​ssam18](https://github.com/ssam18) made their first contribution in [#​2325](spf13/cobra#2325) - [@​dims](https://github.com/dims) made their first contribution in [#​2336](spf13/cobra#2336) **Full Changelog**: <spf13/cobra@v1.10.1...v1.10.2> Thank you to our amazing contributors!!!!! 🐍 🚀 </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43OC4xIiwidXBkYXRlZEluVmVyIjoiNDIuNzguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiS2luZC9EZXBlbmRlbmN5VXBkYXRlIiwicnVuLWVuZC10by1lbmQtdGVzdHMiXX0=--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1279 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Renovate Bot <bot@kriese.eu> Co-committed-by: Renovate Bot <bot@kriese.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed minUsagePadding was defined as a var even though it's never changed anywhere. Since it's a fixed value, using const makes more sense and prevents accidental modifications.
This is just a small cleanup - no functional changes.
Fixes #2323