Warn about --follow-untyped-imports #18249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
force-pushed
the
doc-warn
branch
from
a60eec7 to
ea07ddb
Compare
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Collaborator
|
Thanks for opening this @hauntsaninja! Does it make sense to add the warning to the mypy/docs/source/running_mypy.rst Lines 324 to 328 in 71ec4a6 |
Collaborator
Author
|
Sure, added it there as well |
JukkaL
reviewed
Dec 6, 2024
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
cdce8p
reviewed
Dec 7, 2024
Comment on lines
+290
to
+297
| # mypy.ini | ||
| [mypy-untyped_package.*] | ||
| follow_untyped_imports = True | ||
|
|
||
| # pyproject.toml | ||
| [[tool.mypy.overrides]] | ||
| module = ["untyped_package.*"] | ||
| follow_untyped_imports = true |
Collaborator
There was a problem hiding this comment.
We could use sphinx_inline_tabs for that. Opened #18262 for it.
hauntsaninja
added a commit
that referenced
this pull request
Dec 17, 2024
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.