Skip to content

Conversation

@joeportela
Copy link
Contributor

Adding a flag to ignore changes to POT-Creation-Date when performing updates or checks.
I use a CI check that ensures my .po files are updated before merging, but there is always a diff on POT-Creation-Date.

Related to #725 - but solving (my) problem via update instead of extract.

@joeportela
Copy link
Contributor Author

Ping @akx
Any interest in this PR?

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! As mentioned inside, I think it could be more intuitive for the kwarg to be positive (and default to True).

@joeportela
Copy link
Contributor Author

Thank you for the contribution! As mentioned inside, I think it could be more intuitive for the kwarg to be positive (and default to True).

My pleasure, thanks for taking a look! Just updated per your suggestion.

@joeportela joeportela requested a review from akx July 5, 2023 19:18
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #999 (620fc1d) into master (1747d22) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   90.90%   90.91%           
=======================================
  Files          25       25           
  Lines        4356     4358    +2     
=======================================
+ Hits         3960     3962    +2     
  Misses        396      396           
Impacted Files Coverage Δ
babel/messages/catalog.py 95.72% <100.00%> (+0.01%) ⬆️
babel/messages/frontend.py 87.40% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay!

@akx akx merged commit 9ef53c6 into python-babel:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants