Skip to content

Conversation

@mhsmith
Copy link
Member

@mhsmith mhsmith commented Mar 24, 2025

This tag format was originally defined in PEP 738, and is now documented in the compatibility tag spec.

Like macOS and iOS, we define a public function which yields a sequence of tags from a maximum platform version down to a minimum. However, Android is a bit simpler because its version is expressed as an integer.

@mhsmith
Copy link
Member Author

mhsmith commented Apr 2, 2025

@brettcannon: You reviewed the similar changes for iOS recently; are you able to take a look at this?

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change to keep the tests a bit more robust.

mhsmith and others added 2 commits April 14, 2025 20:21
Co-authored-by: Brett Cannon <brett@python.org>
@mhsmith mhsmith requested a review from brettcannon April 14, 2025 19:28
@brettcannon brettcannon merged commit 8e49b43 into pypa:main Apr 15, 2025
33 checks passed
@mhsmith
Copy link
Member Author

mhsmith commented Apr 16, 2025

Thanks!

@pradyunsg Any chance of getting this released and vendored in time for pip 25.1 next week? The overall plan is in pypa/pip#13299.

@pradyunsg pradyunsg mentioned this pull request Apr 17, 2025
@pradyunsg
Copy link
Member

I've filed a tracking issue for cutting the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants