Skip to content

Conversation

@mazza-av
Copy link
Contributor

This PR intends to replace #2088 and closes #1634.

I have attempted to address the comments left by @jeanas.

@jeanas
Copy link
Contributor

jeanas commented May 11, 2023

There is an error in CI:

E     File "/home/runner/work/pygments/pygments/pygments/lexers/graphql.py", line 119
E       ("\}", Punctuation, "#pop"),
E        ^
E   SyntaxError: invalid escape sequence
@jeanas
Copy link
Contributor

jeanas commented May 11, 2023

@mazza-av I've added some commits to simplify your lexer, eliminating redundant states.

Let me know if that looks good. If so I'll merge it.

@jeanas jeanas mentioned this pull request May 11, 2023
@mazza-av
Copy link
Contributor Author

@jeanas the changes look good to me. I've added a docstring to the lexer that was missing.

@jeanas jeanas merged commit 2401866 into pygments:master May 14, 2023
@jeanas
Copy link
Contributor

jeanas commented May 14, 2023

Thank you!

@kiran94
Copy link

kiran94 commented May 15, 2023

Thanks @jeanas and @mazza-av 😄

I'm unfamiliar with the pygments release cycle. Would you be able to help me understand when this change would be released to pypi?

@Anteru
Copy link
Collaborator

Anteru commented May 15, 2023

I try to make a release once a quarter. So sometime late July/early August for this feature, as new lexers etc. go into a new minor release (whereas we make point releases as needed.)

@Anteru Anteru added the A-lexing area: changes to individual lexers label Aug 5, 2023
@Anteru Anteru added this to the 2.16.0 milestone Aug 5, 2023
@mazza-av mazza-av deleted the graphql-support branch December 14, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lexing area: changes to individual lexers

4 participants