Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.36.1
Choose a base ref
...
head repository: protocolbuffers/protobuf-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.36.2
Choose a head ref
  • 3 commits
  • 14 files changed
  • 1 contributor

Commits on Dec 23, 2024

  1. all: start v1.36.1-devel 

    Change-Id: I7c57fd7034f1a55e25fb0e5654c0e9fcde14d4c4
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/637938
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Chressie Himpel <chressie@google.com>
    @stapelberg
    stapelberg committed Dec 23, 2024
    Configuration menu
    Copy the full SHA
    c0c814f View commit details
    Browse the repository at this point in the history

  2. internal/impl: fix WhichOneof() to work with synthetic oneofs 

    This is the equivalent of CL 638495, but for the Opaque API.

While the behavior is the same for non-synthetic oneofs between
the Open Struct API and Opaque API, the behavior for synthetic oneofs
is not the same: Because the Opaque API uses a bitfield to store
presence, we need to use the Opaque presence check in WhichOneof().

This CL extends the testproto generator to use the protoc
command-line flag for the test3 testproto (which specifies
syntax = "proto3";), as the in-file api_level is only available
in .proto files using editions (but editions does not use synthetic
oneofs for optional fields, only proto3 does).

For golang/protobuf#1659

Change-Id: I0a1fd6e5fc6f96eeab043f966728ce2a14dbd446
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/638515
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Chressie Himpel <chressie@google.com>
    @stapelberg
    stapelberg committed Dec 23, 2024
    Configuration menu
    Copy the full SHA
    8878926 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2025

  1. all: release v1.36.2 

    Change-Id: If65cf0b9b0dbf5ee87344d75c663c3305506f298
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641015
Reviewed-by: Chressie Himpel <chressie@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    @stapelberg
    stapelberg committed Jan 7, 2025
    Configuration menu
    Copy the full SHA
    12c6ebd View commit details
    Browse the repository at this point in the history
Loading