Fix panic in tlsRoundTripper when CA file is absent
#792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndk
force-pushed
the
main
branch
2 times, most recently
from
f758ef5 to
f2fad92
Compare
|
Change here seems plausible. I'm frequently being plagued by this crash. Any chance this could be reviewed/merged? |
|
We got around this by setting the |
Signed-off-by: Andrey Karpov <ndk@users.noreply.github.com>
krajorama
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheus/prometheus#16622 (comment)
Prevents a nil-pointer panic in
tlsRoundTripperthat occurred when cert_file/key_file were set but no ca_file, and the CA reload failed. The code now returns a descriptive error instead of crashing.