Skip to content

Commit 5ab175c

Browse files
pjanottiatoulme
andauthored
[chore] Fix TestPerfCounter_Reset test (#36726)
#### Description Fix the TestPerfCounter_Reset that is failing consistently. ```terminal === FAIL: . TestPerfCounter_Reset (0.00s) watcher_test.go:131: Error Trace: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/winperfcounters/watcher_test.go:131 Error: Both arguments must be pointers Test: TestPerfCounter_Reset ``` Root case: after upgrading `testify` circa of 2 weeks ago, since it included: > NotSame should fail if args are not pointers stretchr/testify#1661 by @sikehish in stretchr/testify#1664 See https://github.com/stretchr/testify/releases #### Testing Local test run Co-authored-by: Antoine Toulme <atoulme@splunk.com>
1 parent 6552f4f commit 5ab175c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎pkg/winperfcounters/watcher_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func TestPerfCounter_Reset(t *testing.T) {
128128

129129
// new query is different instance of same counter.
130130
require.NoError(t, err)
131-
assert.NotSame(t, handle, pc.handle)
131+
assert.NotEqual(t, handle, pc.handle)
132132
assert.NotSame(t, query, pc.query)
133133
assert.Equal(t, path, pc.Path())
134134

0 commit comments

Comments
 (0)