-
Notifications
You must be signed in to change notification settings - Fork 804
feat(forms): allow null
as initial value
#2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Romain Hamel <rom.hml@gmail.com>
Co-authored-by: Romain Hamel <rom.hml@gmail.com>
I've created a new feature request for the model modifier (#2281). I'll update this PR to only include the type changes. After that we can discuss the modifier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
@romhml Do we need to do this on |
Yes, I'll take care of it. |
Co-authored-by: Romain Hamel <rom.hml@gmail.com>
Now actually trying this ( Can someone confirm this works? |
Hello @Gerbuuun But @KazariEX found the problem (Thank you !) and it is in the tsconfig configuration :
I'm going to create a new issue to see if we can find a solution. |
🔗 Linked issue
Resolves #1210
❓ Type of change
📚 Description
Added a model modifier to
UInput
andUTextarea
to make the value returnnull
if the field value is falsy (because initial values may not be a string?).I'm not actually sure if the type change is allowed like this.
Does the native element support an initial value of
null
? I suppose it is similar toundefined
...📝 Checklist