fix(Modal/Slideover): bind transition class to TransitionChild for Vue 3.5
#2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary fix for Headless UI + Vue 3.5 Modal enter transition.
benjamincanac
requested changes
Sep 20, 2024
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
benjamincanac
approved these changes
Sep 20, 2024
patrick-hofmann
pushed a commit
to patrick-hofmann/nuxt-ui
that referenced
this pull request
Oct 3, 2024
…Vue 3.5 (nuxt#2227) Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for Headless UI + Vue 3.5 Modal enter transition.
🔗 Linked issue
Resolves #2127
❓ Type of change
📚 Description
This PR introduces a temporary fix for the issue where the enter transition for modals is no longer functioning after upgrading to Vue 3.5.x. The issue stems from changes in Vue's transition handling, specifically with how it interacts with the
enterFromclass. This fix manually applies theenterFromclass to theTransitionChildcomponent in order to restore the expected behavior.Without this fix, modals may fail to animate correctly on enter, which can affect user experience
📝 Checklist