Skip to content

Commit fc24e03

Browse files
hywaxbenjamincanac
authored andcommitted
fix(Carousel/Tree): add type to button elements for accessibility (#4493)
1 parent 1902492 commit fc24e03

File tree

4 files changed

+178
-177
lines changed

4 files changed

+178
-177
lines changed

‎src/runtime/components/Carousel.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,7 @@ defineExpose({
336336
<div v-if="dots" :class="ui.dots({ class: props.ui?.dots })">
337337
<template v-for="(_, index) in scrollSnaps" :key="index">
338338
<button
339+
type="button"
339340
:aria-label="t('carousel.goto', { slide: index + 1 })"
340341
:class="ui.dot({ class: props.ui?.dot, active: selectedIndex === index })"
341342
:data-state="selectedIndex === index ? 'active' : undefined"

‎src/runtime/components/Tree.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ const defaultExpanded = computed(() =>
163163
@toggle="item.onToggle"
164164
@select="item.onSelect"
165165
>
166-
<button :disabled="item.disabled || disabled" :class="ui.link({ class: [props.ui?.link, item.ui?.link, item.class], selected: isSelected, disabled: item.disabled || disabled })">
166+
<button type="button" :disabled="item.disabled || disabled" :class="ui.link({ class: [props.ui?.link, item.ui?.link, item.class], selected: isSelected, disabled: item.disabled || disabled })">
167167
<slot :name="((item.slot || 'item') as keyof TreeSlots<T>)" v-bind="{ index, level, expanded: isExpanded, selected: isSelected }" :item="(item as Extract<NestedItem<T>, { slot: string; }>)">
168168
<slot :name="((item.slot ? `${item.slot}-leading`: 'item-leading') as keyof TreeSlots<T>)" v-bind="{ index, level, expanded: isExpanded, selected: isSelected }" :item="(item as Extract<NestedItem<T>, { slot: string; }>)">
169169
<UIcon

0 commit comments

Comments
 (0)