Skip to content

allow backreference usage in ignoreCustomFragments #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2016
Merged

allow backreference usage in ignoreCustomFragments #738

merged 1 commit into from
Nov 6, 2016

Conversation

@alexlamsl
Copy link
Collaborator

@alexlamsl alexlamsl commented Nov 6, 2016

fixes #733
@alexlamsl alexlamsl merged commit a15beb1 into gh-pages Nov 6, 2016
@alexlamsl alexlamsl deleted the issue-733 branch November 6, 2016 09:30
outaTiME
outaTiME reviewed Nov 7, 2016
View reviewed changes
tests/minifier.js
/<(WC@[\s\S]*?)>(.*?)<\/\1>/
]
}), input);
output = 'foo<wc @bar>baz moo</wc>loo';
Copy link

@outaTiME outaTiME Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output must preserve both tags like input:

probably as follow:

output = 'foo<WC@bar>baz moo</WC@bar>loo';
Copy link
Collaborator Author

@alexlamsl alexlamsl Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the case without ignoreCustomFragments - the case you are interested in is a line above, when nothing's changed, i.e. expects to equal to input 😉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@alexlamsl @outaTiME