fix parsing of attribute quotes #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/htmlparser.js
Outdated
| function populate(index) { | ||
| customAssign = args[index]; | ||
| value = args[index + 1]; | ||
| if (value !== undefined) { |
Owner
There was a problem hiding this comment.
Hm, I think the convention we follow with undefined checks is to do them via typeof (or just !value if it can never be falsy at that point)
Collaborator
Author
There was a problem hiding this comment.
typeof v === 'undefined' is different from v === undefined in that the former allows v to not have been declared yet, whereas the latter will cause a runtime error.
So I only use the former when I need to cover that specific case, to avoid when I have a typo with v 😅
Either way I'm not too fussed, so I'll change it 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
preventAttributesEscapingexposes a few bugs left over from HTML parser's handling of attribute quotes.This PR fixes those plus a few tests.