Skip to content

fix crash in removeOptionalTags #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2016
Merged

fix crash in removeOptionalTags #508

merged 2 commits into from
Feb 29, 2016

Conversation

@alexlamsl
Copy link
Collaborator

@alexlamsl alexlamsl commented Feb 25, 2016

also implement the optional start tag rules for empty element cases
@alexlamsl
Copy link
Collaborator Author

alexlamsl commented Feb 25, 2016

@XhmikosR @kangax fixes for #503 is going to conflict with this, so if you can review and merge this first before I open another PR that would be great.
@alexlamsl alexlamsl mentioned this pull request Feb 25, 2016
Merged
@XhmikosR
Copy link
Collaborator

XhmikosR commented Feb 25, 2016

I'd still squash those 2 last patches, but otherwise it's much better than the previous PR :)
@alexlamsl
Copy link
Collaborator Author

alexlamsl commented Feb 25, 2016

@XhmikosR squashed 🙏
@alexlamsl
Copy link
Collaborator Author

alexlamsl commented Feb 28, 2016

rebased (dist/htmlminifier.min.js is always in the way...)
kangax added a commit that referenced this pull request Feb 29, 2016
@kangax
Merge pull request #508 from alexlamsl/issue-500
b9e525d 
fix crash in removeOptionalTags
@kangax kangax merged commit b9e525d into kangax:gh-pages Feb 29, 2016
@alexlamsl alexlamsl mentioned this pull request Mar 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@alexlamsl @XhmikosR @kangax