mem: Avoid clearing new buffers and clear buffers from simpleBufferPools

[arjan-bal]

RELEASE NOTES:

• mem:
  • Avoid clearing buffers which newly allocated.
  • Clear large buffers (> 1MB) before re-using.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.05%. Comparing base (f448a97) to head (c237d60).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8670      +/-   ##
==========================================
+ Coverage   81.97%   83.05%   +1.08%     
==========================================
  Files         417      417              
  Lines       40788    32296    -8492     
==========================================
- Hits        33435    26823    -6612     
+ Misses       5991     4093    -1898     
- Partials     1362     1380      +18     

Files with missing lines	Coverage Δ
mem/buffer_pool.go	100.00% <100.00%> (ø)

... and 363 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ramaraochavali]

@arjan-bal is this any way related to #8500 - Would it by any chance help to fix this?

[arjan-bal]

@arjan-bal is this any way related to #8500 - Would it by any chance help to fix this?

Hi @ramaraochavali, there isn't a bug in the buffer pool. The Go garbage collector (GC) can reclaim memory held by the pool. To specify a memory limit for the GC, you would need to set the GOMEMLIMIT environment variable.

That said, this change isn't intended to reduce the memory usage of the buffer pool. However, #8705, which isn't part of a tagged release yet, is expected to improve buffer reuse and reduce memory usage.

[ramaraochavali]

@arjan-bal Thank you. We do set GOMEMLIMIT (to limit of container set) in Istio but still seeing memory growth with this. May be we need to reduce that a bit?

Thank you for sharing the other fix #8705